Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor write_ext_handlers_status_to_info_file function #2325

Merged
merged 4 commits into from
Aug 16, 2021

Conversation

dhivyaganesan
Copy link
Contributor

Description

Issue #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made

Quality of Code and Contribution Guidelines

@codecov
Copy link

codecov bot commented Aug 11, 2021

Codecov Report

Merging #2325 (6fa5039) into develop (4ea51f0) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2325      +/-   ##
===========================================
- Coverage    70.80%   70.79%   -0.01%     
===========================================
  Files           97       97              
  Lines        14032    14029       -3     
  Branches      2012     2012              
===========================================
- Hits          9935     9932       -3     
  Misses        3656     3656              
  Partials       441      441              
Impacted Files Coverage Δ
azurelinuxagent/ga/exthandlers.py 86.17% <100.00%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ea51f0...6fa5039. Read the comment docs.

"extensionSupportedFeatures": [name for name, _ in
get_agent_supported_features_list_for_extensions().items()],
"crpSupportedFeatures": [
"supportedFeatures": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test will fail whenever a new supported feature is added to this list. Might be worthwhile to make this list dynamic too? (Something similar to how you're doing it for extensionSupportedFeatures list below)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Updated the logic.

@dhivyaganesan dhivyaganesan merged commit 5be8d90 into Azure:develop Aug 16, 2021
@dhivyaganesan dhivyaganesan deleted the enhancement-waagent-status branch December 17, 2021 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants