-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor write_ext_handlers_status_to_info_file function #2325
Refactor write_ext_handlers_status_to_info_file function #2325
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2325 +/- ##
===========================================
- Coverage 70.80% 70.79% -0.01%
===========================================
Files 97 97
Lines 14032 14029 -3
Branches 2012 2012
===========================================
- Hits 9935 9932 -3
Misses 3656 3656
Partials 441 441
Continue to review full report at Codecov.
|
tests/ga/test_extension.py
Outdated
"extensionSupportedFeatures": [name for name, _ in | ||
get_agent_supported_features_list_for_extensions().items()], | ||
"crpSupportedFeatures": [ | ||
"supportedFeatures": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test will fail whenever a new supported feature is added to this list. Might be worthwhile to make this list dynamic too? (Something similar to how you're doing it for extensionSupportedFeatures list below)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. Updated the logic.
Description
Issue #
PR information
Quality of Code and Contribution Guidelines