Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report transitioning when status file not found #2330

Merged
merged 8 commits into from
Aug 16, 2021

Conversation

larohra
Copy link
Contributor

@larohra larohra commented Aug 13, 2021

Description

Extensions can take up some time to write status file. If the Agent does not find a status file for the extension, then we report an error back to CRP which fails the operation. In order to avoid doing that and to give extensions enough time to write status files, we'll report a transitioning status back to CRP with a clear cut message stating that the status was reported by the Guest Agent due to missing status file.

Issue #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made

Quality of Code and Contribution Guidelines

@codecov
Copy link

codecov bot commented Aug 13, 2021

Codecov Report

Merging #2330 (4079b3e) into develop (5be8d90) will decrease coverage by 0.01%.
The diff coverage is 92.30%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2330      +/-   ##
===========================================
- Coverage    70.79%   70.78%   -0.02%     
===========================================
  Files           97       97              
  Lines        14029    14034       +5     
  Branches      2012     2013       +1     
===========================================
+ Hits          9932     9934       +2     
- Misses        3656     3657       +1     
- Partials       441      443       +2     
Impacted Files Coverage Δ
azurelinuxagent/ga/exthandlers.py 86.22% <92.30%> (+0.05%) ⬆️
azurelinuxagent/ga/collect_telemetry_events.py 90.41% <0.00%> (-1.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5be8d90...4079b3e. Read the comment docs.

kevinclark19a
kevinclark19a previously approved these changes Aug 16, 2021
kevinclark19a
kevinclark19a previously approved these changes Aug 16, 2021
# A fix will follow soon where we will report transitioning status for extensions by default if no status file
# found instead of reporting an error.
if ext_handler_i.should_perform_multi_config_op(extension):
ext_handler_i.create_placeholder_status_file(extension)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that we still have 3 calls to create_placeholder_status_file to create the status file on some error conditions.

Should we rename this function to avoid confusion with the placeholder file mentioned in the publisher's spec, and also remove the default values for the parameters, which seem to be targeted to this one call that you are removing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure let me send an update

Copy link
Member

@narrieta narrieta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the updates!

@larohra larohra merged commit ee13187 into Azure:develop Aug 16, 2021
@larohra larohra deleted the report-transitioning branch August 16, 2021 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants