Add back the ETP preview flag #2339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it with the same value as the prod flag
kevinclark19a
requested review from
dhivyaganesan,
larohra,
nagworld9,
narrieta and
ZhidongPeng
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #2339 +/- ##
========================================
Coverage 70.86% 70.87%
========================================
Files 97 97
Lines 14105 14107 +2
Branches 2029 2029
========================================
+ Hits 9996 9998 +2
Misses 3662 3662
Partials 447 447
Continue to review full report at Codecov.
|
larohra
reviewed
Aug 24, 2021
| @@ -1996,6 +1996,8 @@ def create_handler_env(self): | |||
|
|
|||
| if get_supported_feature_by_name(SupportedFeatureNames.ExtensionTelemetryPipeline).is_supported: | |||
| handler_env[HandlerEnvironment.eventsFolder] = self.get_extension_events_dir() | |||
| # For now, keep the preview key to not break extensions that were using the preview. | |||
There was a problem hiding this comment.
can you also create a TFS task and assign it to me to remove this key eventually. Thanks!
larohra
approved these changes
Aug 24, 2021
dhivyaganesan
approved these changes
Aug 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ETP preview flag back to HandlerEnvironment.json so as not to break extensions already on the preview.
Issue #
PR information
Quality of Code and Contribution Guidelines