Add support for Flatcar Container Linux #2365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krnowak
requested review from
dhivyaganesan,
kevinclark19a,
larohra,
nagworld9,
narrieta and
ZhidongPeng
as code owners
|
|
krnowak
force-pushed
the
krnowak/support-flatcar
branch
from
114a140
to
c71aeae
Compare
larohra
suggested changes
Sep 24, 2021
Flatcar Container Linux is a fork of CoreOS Container Linux and as such, compatible with it. But distro detection code checking `/etc/os-release` will return `flatcar` instead of `coreos`, so make sure that whatever code paths for `flatcar` are the same as for `coreos`.
krnowak
force-pushed
the
krnowak/support-flatcar
branch
from
c71aeae
to
e627c88
Compare
|
Updated. |
Codecov Report
@@ Coverage Diff @@
## develop #2365 +/- ##
===========================================
+ Coverage 70.86% 70.91% +0.04%
===========================================
Files 97 97
Lines 14100 14100
Branches 2031 2031
===========================================
+ Hits 9992 9999 +7
+ Misses 3659 3654 -5
+ Partials 449 447 -2
Continue to review full report at Codecov.
|
larohra
approved these changes
Sep 28, 2021
kevinclark19a
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds support Flatcar Container Linux, which is a fork of CoreOS Container Linux, and is compatible with it. We currently carry a patch in our wa-linux-agent package, and now I'm trying to upstream it.
I wasn't sure if I also need to update the code in
bin/waagent2.0, which seems to be an older version of the project, so for now I left it alone. Please let me know if it needs updating too.PR information
Quality of Code and Contribution Guidelines