Improve error message for vmSettings errors (#2397) #2399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Improve error message for vmSettings errors * Add etag and correlation id * pylint warning Co-authored-by: narrieta <narrieta> (cherry picked from commit ec69119)
narrieta
requested review from
dhivyaganesan,
kevinclark19a,
larohra,
nagworld9 and
ZhidongPeng
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #2399 +/- ##
===========================================
+ Coverage 71.15% 71.17% +0.01%
===========================================
Files 97 97
Lines 14431 14434 +3
Branches 2083 2084 +1
===========================================
+ Hits 10269 10273 +4
Misses 3698 3698
+ Partials 464 463 -1
Continue to review full report at Codecov.
|
dhivyaganesan
approved these changes
Oct 29, 2021
kevinclark19a
approved these changes
Nov 1, 2021
larohra
approved these changes
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: narrieta
(cherry picked from commit 892b5d5)