Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uos support #2420

Merged
merged 3 commits into from
Dec 2, 2021
Merged

Add uos support #2420

merged 3 commits into from
Dec 2, 2021

Conversation

weidongkx
Copy link
Contributor

@weidongkx weidongkx commented Nov 19, 2021

Signed-off-by: weidong weidong@uniontech.com

Description

Issue #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made

Quality of Code and Contribution Guidelines

Signed-off-by: weidong <weidong@uniontech.com>
Copy link
Contributor

@larohra larohra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes LGTM, running automation will approve once I get a green run.

@codecov
Copy link

codecov bot commented Nov 23, 2021

Codecov Report

Merging #2420 (69ace49) into develop (5a46276) will decrease coverage by 0.02%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2420      +/-   ##
===========================================
- Coverage    71.70%   71.67%   -0.03%     
===========================================
  Files          100      100              
  Lines        14680    14684       +4     
  Branches      2325     2327       +2     
===========================================
- Hits         10526    10525       -1     
- Misses        3688     3692       +4     
- Partials       466      467       +1     
Impacted Files Coverage Δ
azurelinuxagent/common/version.py 71.42% <0.00%> (-0.87%) ⬇️
azurelinuxagent/common/osutil/factory.py 94.93% <100.00%> (+0.13%) ⬆️
azurelinuxagent/common/event.py 85.32% <0.00%> (-0.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a46276...69ace49. Read the comment docs.

Copy link
Contributor

@larohra larohra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DCR looks good (apart from known unrelated errors)

@dhivyaganesan can you take a look too please.

@weidongkx
Copy link
Contributor Author

@larohra This PR has not been merged yet. Do I need to make any changes

@larohra larohra merged commit 5620fe9 into Azure:develop Dec 2, 2021
@larohra
Copy link
Contributor

larohra commented Dec 2, 2021

@larohra This PR has not been merged yet. Do I need to make any changes

Done! Sorry for the delay and thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants