-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for python 2.6 to the log collection code #2452
Add support for python 2.6 to the log collection code #2452
Conversation
…ey aren't present in 2.6
…ector__support_2_6
Codecov Report
@@ Coverage Diff @@
## develop #2452 +/- ##
========================================
Coverage 71.88% 71.88%
========================================
Files 101 101
Lines 14964 14968 +4
Branches 2369 2370 +1
========================================
+ Hits 10757 10760 +3
Misses 3728 3728
- Partials 479 480 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if zipfile.Zipfile raises then the finally clause will raise a null (None) reference exception
Description
Relaxes the requirements for the log collection background task to allow for python2.6 to run it. Right now, there aren't any distros that are on python2.6 and also have cgroups enabled (another requirement of that code running), but if/when cgroups are enabled for those distros, the log collection background task will also be enabled for those distros.
Also makes the log collection code python2.6 compatible, which right now allows
waagent -collect-logs
to be ran on distros with python2.6.PR information
Quality of Code and Contribution Guidelines