Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore firewall packets reset error, check enable firewall config flag and extend cgroup extension monitoring expiry time #2509

Merged
merged 4 commits into from
Feb 15, 2022

Conversation

nagworld9
Copy link
Contributor

Description

Issue #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made

Quality of Code and Contribution Guidelines

…g and extend cgroup extension monitoring expiry time

(cherry picked from commit 0ac5dc1)
@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #2509 (ef5fca7) into develop (2939a14) will decrease coverage by 0.00%.
The diff coverage is 75.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2509      +/-   ##
===========================================
- Coverage    71.86%   71.85%   -0.01%     
===========================================
  Files          101      101              
  Lines        15110    15112       +2     
  Branches      2396     2397       +1     
===========================================
  Hits         10859    10859              
- Misses        3766     3767       +1     
- Partials       485      486       +1     
Impacted Files Coverage Δ
azurelinuxagent/common/conf.py 79.31% <0.00%> (ø)
azurelinuxagent/common/osutil/default.py 59.27% <100.00%> (-0.22%) ⬇️
azurelinuxagent/ga/update.py 88.61% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2939a14...ef5fca7. Read the comment docs.

narrieta
narrieta previously approved these changes Feb 14, 2022
Copy link
Member

@narrieta narrieta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor typo

mock_iptables.destination,
wait=mock_iptables.wait))

# Filtering the mock iptable command calls with only the once related to this test.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"with only the ones"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@nagworld9 nagworld9 merged commit 9a11fa9 into Azure:develop Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants