Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable get vmsize while UTs are hanging #2515

Merged

Conversation

kevinclark19a
Copy link
Contributor

Description

The VMSize heartbeat reporting added in #2462 is hanging UTs ran on non-Azure VM systems. This PR is meant to temporarily disable this reporting until #2513 can be merged and fix the bug.


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made

Quality of Code and Contribution Guidelines

@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #2515 (f15f548) into develop (9a11fa9) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2515      +/-   ##
===========================================
- Coverage    71.85%   71.84%   -0.02%     
===========================================
  Files          101      101              
  Lines        15112    15112              
  Branches      2397     2397              
===========================================
- Hits         10859    10857       -2     
- Misses        3767     3772       +5     
+ Partials       486      483       -3     
Impacted Files Coverage Δ
azurelinuxagent/ga/update.py 87.74% <100.00%> (-0.87%) ⬇️
azurelinuxagent/common/utils/restutil.py 84.03% <0.00%> (-0.33%) ⬇️
azurelinuxagent/common/event.py 86.03% <0.00%> (+0.67%) ⬆️
azurelinuxagent/ga/collect_telemetry_events.py 91.43% <0.00%> (+1.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a11fa9...f15f548. Read the comment docs.

@kevinclark19a kevinclark19a merged commit 45a005e into Azure:develop Feb 17, 2022
@kevinclark19a kevinclark19a deleted the temporarily_disable_vm_size branch February 17, 2022 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants