Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suppress legacy cgruop warning in older deamons #2539

Merged
merged 1 commit into from
Mar 24, 2022

Conversation

nagworld9
Copy link
Contributor

Description

Older versions of the daemon (2.2.31-2.2.40) wrote their PID to /sys/fs/cgroup/{cpu,memory}/WALinuxAgent/WALinuxAgent. When running under systemd this could produce invalid resource usage data. Cgroups should not be enabled under this condition.

The agent disables cgroups if it detects above case. This is known issue and so ignore this warning in dcr.

Issue #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made

Quality of Code and Contribution Guidelines

@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #2539 (12b6857) into develop (ae89acd) will increase coverage by 0.06%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2539      +/-   ##
===========================================
+ Coverage    71.99%   72.06%   +0.06%     
===========================================
  Files          102      102              
  Lines        15202    15202              
  Branches      2406     2406              
===========================================
+ Hits         10945    10955      +10     
+ Misses        3776     3770       -6     
+ Partials       481      477       -4     
Impacted Files Coverage Δ
azurelinuxagent/common/event.py 86.03% <0.00%> (+0.67%) ⬆️
azurelinuxagent/ga/collect_telemetry_events.py 92.12% <0.00%> (+2.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae89acd...12b6857. Read the comment docs.

@nagworld9 nagworld9 merged commit b3664e8 into Azure:develop Mar 24, 2022
@nagworld9 nagworld9 deleted the suppress-cgw branch March 24, 2022 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants