Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse missing agent manifests as empty #2615

Merged
merged 1 commit into from
Jun 17, 2022

Conversation

narrieta
Copy link
Member

Old versions of the HGAP can sometimes produce goal states with missing agent manifests, which causes a parsing error while fetching the goal state. The fix parses that as an empty list.

@codecov
Copy link

codecov bot commented Jun 17, 2022

Codecov Report

Merging #2615 (7e39ec8) into release-2.8.0.0 (fcc81a1) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@                 Coverage Diff                 @@
##           release-2.8.0.0    #2615      +/-   ##
===================================================
+ Coverage            72.18%   72.20%   +0.01%     
===================================================
  Files                  102      102              
  Lines                15391    15393       +2     
  Branches              2442     2443       +1     
===================================================
+ Hits                 11110    11114       +4     
+ Misses                3793     3792       -1     
+ Partials               488      487       -1     
Impacted Files Coverage Δ
...protocol/extensions_goal_state_from_vm_settings.py 83.45% <100.00%> (+0.12%) ⬆️
azurelinuxagent/ga/collect_telemetry_events.py 92.12% <0.00%> (+0.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcc81a1...7e39ec8. Read the comment docs.

@narrieta narrieta merged commit b617349 into Azure:release-2.8.0.0 Jun 17, 2022
@narrieta narrieta deleted the agent-manifest branch June 17, 2022 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants