Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitor extension memory cgroups #2632

Merged
merged 4 commits into from
Jul 14, 2022
Merged

Conversation

nagworld9
Copy link
Contributor

@nagworld9 nagworld9 commented Jul 13, 2022

Description

Update the extension unit file having memoryaccounting enabled and create drop-in file for services.
Add the memory controllers to the monitor thread to start tracking those. Stop tracking those controllers once ext uninstall.

Issue #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made

Quality of Code and Contribution Guidelines

@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #2632 (3f40e11) into develop (45018d7) will decrease coverage by 0.00%.
The diff coverage is 73.17%.

❗ Current head 3f40e11 differs from pull request most recent head c9202de. Consider uploading reports for the commit c9202de to get more accurate results

@@             Coverage Diff             @@
##           develop    #2632      +/-   ##
===========================================
- Coverage    71.97%   71.96%   -0.01%     
===========================================
  Files          103      103              
  Lines        15609    15632      +23     
  Branches      2483     2488       +5     
===========================================
+ Hits         11234    11250      +16     
- Misses        3864     3868       +4     
- Partials       511      514       +3     
Impacted Files Coverage Δ
azurelinuxagent/common/cgroupapi.py 81.00% <71.42%> (-0.61%) ⬇️
azurelinuxagent/common/cgroupconfigurator.py 73.47% <72.41%> (-0.21%) ⬇️
azurelinuxagent/ga/exthandlers.py 85.87% <75.00%> (ø)
azurelinuxagent/common/cgroup.py 87.86% <100.00%> (ø)
azurelinuxagent/common/utils/fileutil.py 79.69% <0.00%> (+0.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45018d7...c9202de. Read the comment docs.

@narrieta
Copy link
Member

@nagworld9 can we improve the description (short summary of what the issue and fix are). Thanks

Copy link
Member

@narrieta narrieta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGT, please update the description

@nagworld9
Copy link
Contributor Author

LGT, please update the description

Updated, thanks for the approval.

@nagworld9 nagworld9 merged commit 71edfe3 into Azure:develop Jul 14, 2022
@nagworld9 nagworld9 deleted the TASK-10956552 branch July 14, 2022 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants