Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Fedora disto #2642

Merged
merged 2 commits into from
Oct 31, 2022
Merged

Implement Fedora disto #2642

merged 2 commits into from
Oct 31, 2022

Conversation

vittyvk
Copy link
Contributor

@vittyvk vittyvk commented Aug 3, 2022

Fedora distribution is not covered by RedhatOS classes, create
a separate one for it.

Note: this patch was previosly carried out-of-tree, fedora packages
already have it included.

Signed-off-by: Vitaly Kuznetsov vkuznets@redhat.com

Description

Issue #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made

Quality of Code and Contribution Guidelines

Fedora distribution is not covered by Redhat*OS* classes, create
a separate one for it.

Note: this patch was previosly carried out-of-tree, fedora packages
already have it included.

Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #2642 (e011623) into develop (a1f3049) will decrease coverage by 0.07%.
The diff coverage is 45.65%.

@@             Coverage Diff             @@
##           develop    #2642      +/-   ##
===========================================
- Coverage    72.06%   71.98%   -0.08%     
===========================================
  Files          103      104       +1     
  Lines        15702    15748      +46     
  Branches      2237     2241       +4     
===========================================
+ Hits         11315    11336      +21     
- Misses        3872     3896      +24     
- Partials       515      516       +1     
Impacted Files Coverage Δ
azurelinuxagent/common/osutil/factory.py 91.11% <33.33%> (-2.00%) ⬇️
azurelinuxagent/common/osutil/fedora.py 46.51% <46.51%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@vittyvk
Copy link
Contributor Author

vittyvk commented Oct 20, 2022

Ping

@cjp256
Copy link

cjp256 commented Oct 27, 2022

@narrieta can you take a look at this PR? Would be a great starting point for Fedora support.

@narrieta
Copy link
Member

@vittyvk Sorry, for the delay. LGTM, will do one automation run and merge when it completes.

You tested your changes on your side, correct? Currently we do not have the infrastructure to test Fedora.

@vittyvk
Copy link
Contributor Author

vittyvk commented Oct 31, 2022

@narrieta Yes, Fedora was carrying these patches for some time already. I'm smoke-testing every new Fedora build (I'm the package maintainer).

@narrieta narrieta merged commit a906320 into Azure:develop Oct 31, 2022
@narrieta
Copy link
Member

@vittyvk Thank you. Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants