Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update traceback.format_exception etype argument #2663

Merged
merged 3 commits into from
Sep 10, 2022

Conversation

nagworld9
Copy link
Contributor

Description

Changed in version 3.10: The etype parameter has been renamed to exc and is now positional-only.
That is breaking the traceback.format_exception call since we pass value as keyword argument.

In older versions the etype parameter is mandatory argument. So, changing from keyword argument to positional argument should fix the problem in all 3. * Versions.

Issue #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made

Quality of Code and Contribution Guidelines

@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #2663 (b5f77ff) into develop (12f444b) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #2663   +/-   ##
========================================
  Coverage    71.96%   71.96%           
========================================
  Files          103      103           
  Lines        15679    15679           
  Branches      2486     2486           
========================================
  Hits         11283    11283           
  Misses        3879     3879           
  Partials       517      517           
Impacted Files Coverage Δ
azurelinuxagent/common/utils/textutil.py 62.50% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nagworld9 nagworld9 merged commit 45e960d into Azure:develop Sep 10, 2022
@nagworld9 nagworld9 deleted the format-exception branch September 10, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants