Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reset the quotas when agent drop the cgroup support #2693

Merged
merged 6 commits into from
Oct 31, 2022

Conversation

nagworld9
Copy link
Contributor

Description

Cleanup the drop file files to reset the quotas when agent drop the cgroup support from supported list of distros

Issue #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made

Quality of Code and Contribution Guidelines

@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Merging #2693 (2b9052a) into release-2.9.0.0 (43cf6a2) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

@@                 Coverage Diff                 @@
##           release-2.9.0.0    #2693      +/-   ##
===================================================
- Coverage            71.98%   71.91%   -0.07%     
===================================================
  Files                  103      103              
  Lines                15698    15713      +15     
  Branches              2245     2247       +2     
===================================================
  Hits                 11300    11300              
- Misses                3881     3895      +14     
- Partials               517      518       +1     
Impacted Files Coverage Δ
azurelinuxagent/common/cgroupconfigurator.py 71.83% <0.00%> (-1.75%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@narrieta narrieta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should add some logging info and handle errors removing the files

@nagworld9 nagworld9 merged commit 49d4f7c into Azure:release-2.9.0.0 Oct 31, 2022
@nagworld9 nagworld9 deleted the reset-cpu-quota branch October 31, 2022 18:31
nagworld9 added a commit to nagworld9/WALinuxAgent that referenced this pull request Nov 3, 2022
* reset the quotas when agent drop the cgroup support

* address comments

* log removed file names

* remove only agent created files

* fix pylint error

* fix agent drop in path str

(cherry picked from commit 49d4f7c)
nagworld9 added a commit that referenced this pull request Nov 3, 2022
* reset the quotas when agent drop the cgroup support

* address comments

* log removed file names

* remove only agent created files

* fix pylint error

* fix agent drop in path str

(cherry picked from commit 49d4f7c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants