Add ARM64 to the daily test run #2734
Conversation
narrieta
requested review from
ZhidongPeng,
nagworld9 and
maddieford
as code owners
| @@ -46,32 +48,34 @@ platform: | |||
| min: 2 | |||
| azure: | |||
| marketplace: "$(marketplace_image)" | |||
| vhd: $(vhd) | |||
| vhd: "" | |||
There was a problem hiding this comment.
I will use the VHD parameter in a future PR
| value: "" | ||
| - name: default_location | ||
| value: "westus2" | ||
|
|
There was a problem hiding this comment.
Now that those variables are generated by the combinator, overriding them from the command line has no effect. In future PRs I will replace those in favor of using JSON files defining the test suites, as we discussed earlier.
| location: $(default_location) | ||
| # Mariner 2 ARM64 is not available in westus2 currently; use eastus. | ||
| - marketplace_image: "microsoftcblmariner cbl-mariner cbl-mariner-2-arm64 latest" | ||
| location: "eastus" |
There was a problem hiding this comment.
This list will be generated automatically in future PRs from the JSON definition files
| @@ -28,7 +28,7 @@ | |||
| from lisa import schema # pylint: disable=E0401 | |||
| from lisa.messages import ( # pylint: disable=E0401 | |||
| MessageBase, | |||
| TestResultMessage, | |||
| TestResultMessageBase, | |||
There was a problem hiding this comment.
Using the Base class also captures SubTests. We don't have any of those currently, but decided to make the code more generic in case we use them.
| if isinstance(message, TestResultMessageBase): | ||
| image = message.information.get('image') | ||
| if image is not None: | ||
| message.name = image |
There was a problem hiding this comment.
using the image instead of the distro allows to distinguish Mariner 1 & 2
|
|
||
| concurrency: 10 | ||
|
|
||
| notifier: | ||
| - type: env_stats |
There was a problem hiding this comment.
This notifier was copied from the sample on which I based the original runbook. Taking a look at its report, it does not provide anything useful for our scenario, so I'm removing it.
Codecov Report
@@ Coverage Diff @@
## develop #2734 +/- ##
========================================
Coverage 72.04% 72.04%
========================================
Files 104 104
Lines 15832 15832
Branches 2265 2265
========================================
Hits 11406 11406
Misses 3912 3912
Partials 514 514 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
I'm starting with Mariner 2 and will add more ARM64 distros in future PRs