-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update github hosted build runner for Unit tests #2755
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2755 +/- ##
===========================================
- Coverage 72.03% 71.99% -0.05%
===========================================
Files 104 104
Lines 15831 15831
Branches 2264 2264
===========================================
- Hits 11404 11397 -7
- Misses 3909 3913 +4
- Partials 518 521 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@@ -43,24 +51,24 @@ jobs: | |||
- python-version: 2.7 | |||
PYLINTOPTS: "--rcfile=ci/2.7.pylintrc --ignore=tests_e2e,makepkg.py" | |||
|
|||
- python-version: 3.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we keep python 3.4? we should check telemetry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are very low and around 2000 vms running on py 3.4. All of them are either ubuntu 14 or Debian 8
@@ -231,6 +232,7 @@ def test_calls_collect_logs_with_proper_mode(self, mock_log_collector, *args): | |||
def test_calls_collect_logs_on_valid_cgroups(self, mock_log_collector): | |||
try: | |||
CollectLogsHandler.enable_cgroups_validation() | |||
mock_log_collector.run = Mock() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
run method has protocol initialization and that is internally making network calls which ls happening in loop due to retry setup on failures.
Description
Currently builds running on ubuntu 18 which is deprecated now. Migrated to ubuntu 20.
Issue #
PR information
Quality of Code and Contribution Guidelines