update github hosted build runner for Unit tests #2755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nagworld9
requested review from
narrieta,
ZhidongPeng and
maddieford
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #2755 +/- ##
===========================================
- Coverage 72.03% 71.99% -0.05%
===========================================
Files 104 104
Lines 15831 15831
Branches 2264 2264
===========================================
- Hits 11404 11397 -7
- Misses 3909 3913 +4
- Partials 518 521 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
narrieta
reviewed
Feb 9, 2023
| @@ -43,24 +51,24 @@ jobs: | |||
| - python-version: 2.7 | |||
| PYLINTOPTS: "--rcfile=ci/2.7.pylintrc --ignore=tests_e2e,makepkg.py" | |||
|
|
|||
| - python-version: 3.4 | |||
There was a problem hiding this comment.
should we keep python 3.4? we should check telemetry
There was a problem hiding this comment.
They are very low and around 2000 vms running on py 3.4. All of them are either ubuntu 14 or Debian 8
narrieta
previously approved these changes
Feb 9, 2023
maddieford
previously approved these changes
Feb 10, 2023
nagworld9
commented
Feb 11, 2023
| @@ -231,6 +232,7 @@ def test_calls_collect_logs_with_proper_mode(self, mock_log_collector, *args): | |||
| def test_calls_collect_logs_on_valid_cgroups(self, mock_log_collector): | |||
| try: | |||
| CollectLogsHandler.enable_cgroups_validation() | |||
| mock_log_collector.run = Mock() | |||
There was a problem hiding this comment.
run method has protocol initialization and that is internally making network calls which ls happening in loop due to retry setup on failures.
narrieta
approved these changes
Feb 13, 2023
maddieford
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently builds running on ubuntu 18 which is deprecated now. Migrated to ubuntu 20.
Issue #
PR information
Quality of Code and Contribution Guidelines