Use unique name for test VMs. Remove hardcoded log path #2767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narrieta
requested review from
ZhidongPeng,
nagworld9 and
maddieford
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #2767 +/- ##
========================================
Coverage 71.99% 71.99%
========================================
Files 104 104
Lines 15831 15831
Branches 2264 2264
========================================
Hits 11397 11397
Misses 3913 3913
Partials 521 521 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
narrieta
commented
Feb 21, 2023
| @@ -99,9 +99,9 @@ def enable( | |||
| extension_parameters | |||
| ).result(timeout=_TIMEOUT)) | |||
|
|
|||
| if result.provisioning_state != 'Succeeded': | |||
There was a problem hiding this comment.
This check is failing from time to time because we get 'Updating'; that should not be reported as a failure.
nagworld9
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been using the distro name to distinguish test VMs in the main log, the junit results, and to create the file name for test logs. With the support for location, vm_size and "owns VM" in my previous PR, the distro name is no longer unique. This PR fixes this, adding the location, or the test suite name for suites that own the VM, to the distro name.
The AgentTestSuite was hardcoding the location of the log files to $HOME/logs. Now this location can be passed as a parameter to the runbook.