Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add distros to end-to-end automation #2769

Merged
merged 4 commits into from
Feb 24, 2023
Merged

Conversation

narrieta
Copy link
Member

Including additional distros for the daily run, and increasing the concurrency level.

Fixes #2588

@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Merging #2769 (f83951a) into develop (3aebcdd) will increase coverage by 0.01%.
The diff coverage is 82.37%.

@@             Coverage Diff             @@
##           develop    #2769      +/-   ##
===========================================
+ Coverage    71.97%   71.99%   +0.01%     
===========================================
  Files          103      104       +1     
  Lines        15692    15831     +139     
  Branches      2486     2264     -222     
===========================================
+ Hits         11295    11397     +102     
- Misses        3881     3913      +32     
- Partials       516      521       +5     
Impacted Files Coverage Δ
azurelinuxagent/ga/collect_logs.py 81.15% <0.00%> (-0.36%) ⬇️
azurelinuxagent/common/logcollector.py 88.35% <33.33%> (+0.04%) ⬆️
azurelinuxagent/common/osutil/factory.py 91.11% <33.33%> (-2.00%) ⬇️
azurelinuxagent/daemon/main.py 71.42% <33.33%> (+0.29%) ⬆️
azurelinuxagent/common/osutil/fedora.py 46.51% <46.51%> (ø)
azurelinuxagent/common/cgroupconfigurator.py 72.19% <57.89%> (-1.39%) ⬇️
azurelinuxagent/common/protocol/hostplugin.py 87.76% <75.00%> (+0.09%) ⬆️
azurelinuxagent/common/protocol/wire.py 77.37% <84.90%> (-1.18%) ⬇️
azurelinuxagent/ga/exthandlers.py 86.06% <87.50%> (+0.37%) ⬆️
azurelinuxagent/common/protocol/goal_state.py 95.59% <94.52%> (+0.27%) ⬆️
... and 25 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@@ -11,7 +11,9 @@ schedules:
- develop
always: true

# no PR triggers
trigger:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cleanup pipeline is being run on PRs. Adding the trigger to make it match the settings of the main pipeline.

maddieford
maddieford previously approved these changes Feb 23, 2023
@@ -123,7 +123,7 @@ combinator:
location: $(location)
vm_size: $(vm_size)

concurrency: 10
concurrency: 16
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does concurrency here refer to?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, I see the Teams chat discussion

# debian_8: "credativ Debian 8 latest"
#
alma_9: "almalinux:almalinux:9-gen2:latest"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we keep same format across all distros? or is it supposed to be that way?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this was a copy-n-paste and forgot to replace the :

i want to use spaces all over because improves readibility. i'll update this one

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw (LISA accepts both, CLI requires colon)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see few other places too; can you also update those? Thanks.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@narrieta narrieta merged commit 5aa1df6 into Azure:develop Feb 24, 2023
@narrieta narrieta deleted the distros branch February 24, 2023 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants