Add support for Azure clouds #2771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narrieta
requested review from
ZhidongPeng,
nagworld9 and
maddieford
as code owners
narrieta
commented
Feb 27, 2023
| @@ -44,23 +50,6 @@ parameters: | |||
| - failed | |||
| - no | |||
|
|
|||
| variables: | |||
There was a problem hiding this comment.
These variables are used only by the "Execute tests" tasks, so I removed them and referenced the parameters directly in that task.
narrieta
commented
Feb 27, 2023
| SecretsFilter: '*' | ||
| RunAsPreJob: true |
There was a problem hiding this comment.
'RunAsPreJob' makes the secrets available to all the tasks, this is not needed since the only task that uses them is "Execute tests". I removed this parameter to use the default value (false), which makes the secrets available only to the next task and I moved the task to precede "Execute tests".
Codecov Report
@@ Coverage Diff @@
## develop #2771 +/- ##
========================================
Coverage 71.99% 71.99%
========================================
Files 104 104
Lines 15831 15831
Branches 2264 2264
========================================
Hits 11397 11397
Misses 3913 3913
Partials 521 521 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
maddieford
approved these changes
Feb 28, 2023
nagworld9
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for executing the Azure pipeline on different clouds.
It adds a new variable to the pipeline, 'connection_info' which points to the keyvault where the connection parameters are stored.
It also separates the identity used to connect to the container registry from the identity used for management operations (create VMs, execute extensions, etc).
Lastly, it adds a new parameter, 'cloud' to the LISA runbook.