-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Azure clouds #2771
Conversation
@@ -44,23 +50,6 @@ parameters: | |||
- failed | |||
- no | |||
|
|||
variables: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These variables are used only by the "Execute tests" tasks, so I removed them and referenced the parameters directly in that task.
SecretsFilter: '*' | ||
RunAsPreJob: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'RunAsPreJob' makes the secrets available to all the tasks, this is not needed since the only task that uses them is "Execute tests". I removed this parameter to use the default value (false), which makes the secrets available only to the next task and I moved the task to precede "Execute tests".
Codecov Report
@@ Coverage Diff @@
## develop #2771 +/- ##
========================================
Coverage 71.99% 71.99%
========================================
Files 104 104
Lines 15831 15831
Branches 2264 2264
========================================
Hits 11397 11397
Misses 3913 3913
Partials 521 521 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried checking connection_info variable in the pipeline, I didn't find it and we can discuss offline.
This PR adds support for executing the Azure pipeline on different clouds.
It adds a new variable to the pipeline, 'connection_info' which points to the keyvault where the connection parameters are stored.
It also separates the identity used to connect to the container registry from the identity used for management operations (create VMs, execute extensions, etc).
Lastly, it adds a new parameter, 'cloud' to the LISA runbook.