-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fetch full distro version for mariner #2773
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2773 +/- ##
===========================================
- Coverage 71.99% 71.99% -0.01%
===========================================
Files 104 104
Lines 15839 15841 +2
Branches 2265 2266 +1
===========================================
Hits 11404 11404
- Misses 3913 3914 +1
- Partials 522 523 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
azurelinuxagent/common/future.py
Outdated
|
||
# Fixing is the problem https://github.com/Azure/WALinuxAgent/issues/2715. Distro.linux_distribution method not retuning full version | ||
# If best is true, the most precise version number out of all examined sources is returned. | ||
if osinfo and "mariner" in osinfo[0].lower(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this a check for None on distro? is it needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like in this context, it's not needed. Initially thought, we may have empty list but above we are appending some value. So, it will never be empty. I'll update
Description
Addressing the issue #2715.
distro.linux_distribution()
not returning full distro version.Issue #
PR information
Quality of Code and Contribution Guidelines