remove version suffix from extension slice #2782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nagworld9
requested review from
narrieta,
ZhidongPeng and
maddieford
as code owners
maddieford
previously approved these changes
Mar 8, 2023
narrieta
reviewed
Mar 9, 2023
| @@ -455,6 +455,11 @@ def __create_all_files(files_to_create): | |||
|
|
|||
| def is_extension_resource_limits_setup_completed(self, extension_name, cpu_quota=None): | |||
| unit_file_install_path = systemd.get_unit_file_install_path() | |||
| old_extension_slice_path = os.path.join(unit_file_install_path, SystemdCgroupsApi.get_extension_slice_name(extension_name, old_slice=True)) | |||
| # clean up the old slice from the desk | |||
narrieta
reviewed
Mar 9, 2023
| def get_extension_slice_name(extension_name, old_slice=False): | ||
| # old slice includes <HandlerName>.<ExtensionName>-<HandlerVersion> | ||
| # new slice without version <HandlerName>.<ExtensionName> | ||
| if not old_slice: |
There was a problem hiding this comment.
maybe add a comment that we renamed the slice and why for future reference?
narrieta
previously approved these changes
Mar 9, 2023
Codecov Report
@@ Coverage Diff @@
## develop #2782 +/- ##
===========================================
- Coverage 71.99% 71.98% -0.01%
===========================================
Files 104 104
Lines 15844 15851 +7
Branches 2268 2271 +3
===========================================
+ Hits 11407 11411 +4
- Misses 3914 3915 +1
- Partials 523 525 +2
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
narrieta
approved these changes
Mar 9, 2023
maddieford
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Today we are creating extension_slice with version on it. Example
└─azure-vmextensions.slice
└─azure-vmextensions-Microsoft.Azure.Monitor.AzureMonitorLinuxAgent_1.25.1.slice
└─enable_c1f3b25b-93d5-4594-9a2d-ce5deee5536f.scope
└─3319627 /usr/bin/python3 /var/lib/waagent/Microsoft.Azure.Monitor.AzureMonitorLinuxAgent-1.25.1/agent.py -metrics
This makes it difficult for user to override the limits because they need to place drop-in files on every upgrade if extension slice is different for each version.
In this pr, I have updated logic and creating slice without version and will be same slice even extension updated to new version. We only modify it if the extension publishers change the limits. That way users don't need to create drop files again if they already done it for having custom settings.
Issue #
PR information
Quality of Code and Contribution Guidelines