-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support int type for eventPid and eventTid fields #2786
Conversation
@@ -58,6 +58,8 @@ class ExtensionEventSchema(object): | |||
"EventTid":"2", | |||
"OperationId":"Guid (str)" | |||
} | |||
|
|||
From next version(2.10+) we accept integer values for EventPid and EventTid fields. But we still support string type for backward compatability |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assumed this go in next release and version would be 2.10
Codecov Report
@@ Coverage Diff @@
## develop #2786 +/- ##
========================================
Coverage 71.99% 71.99%
========================================
Files 104 104
Lines 15851 15857 +6
Branches 2271 2273 +2
========================================
+ Hits 11412 11417 +5
Misses 3915 3915
- Partials 524 525 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
||
clean_string = lambda x: x.strip() if x is not None else x | ||
def _clean_value(k, v): | ||
if v is not None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if v is None, _clean_value will return None and the conversion below will raise an exception
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, where? I kept it same as we have today so that downstream code will work like before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
never mind, you are converting the key, not the value
Description
Today we only support string value for eventPid and EventTid. As these fields are ids and ids are generally numeric in nature, so changing logic to support int values too.
Issue #
PR information
Quality of Code and Contribution Guidelines