retry ssh run in e2e tests #2788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nagworld9
requested review from
narrieta,
ZhidongPeng and
maddieford
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #2788 +/- ##
========================================
Coverage 71.99% 71.99%
========================================
Files 104 104
Lines 15857 15857
Branches 2273 2273
========================================
Hits 11417 11417
Misses 3915 3915
Partials 525 525 see 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
narrieta
reviewed
Mar 21, 2023
tests_e2e/tests/lib/retry.py
Outdated
| # Instance of 'Exception' has no 'exit_code' member (no-member) - Disabled: e is actually an CommandError | ||
| if e.exit_code != 255 or attempts == 0: # pylint: disable=no-member | ||
| raise | ||
| log.warning("The operation failed with SSH Connection time out, retrying in 30 secs. Error: %s", e) |
There was a problem hiding this comment.
could we log the actual stderr instead of "failed with SSH Connection time out,"?
narrieta
previously approved these changes
Mar 21, 2023
maddieford
previously approved these changes
Mar 22, 2023
nagworld9
force-pushed
the
retry-ssh-run
branch
from
9780951
to
4e68cf3
Compare
narrieta
approved these changes
Mar 22, 2023
maddieford
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
retry ssh run in e2e tests
Issue #
PR information
Quality of Code and Contribution Guidelines