-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
retry ssh run in e2e tests #2788
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2788 +/- ##
========================================
Coverage 71.99% 71.99%
========================================
Files 104 104
Lines 15857 15857
Branches 2273 2273
========================================
Hits 11417 11417
Misses 3915 3915
Partials 525 525 see 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
tests_e2e/tests/lib/retry.py
Outdated
# Instance of 'Exception' has no 'exit_code' member (no-member) - Disabled: e is actually an CommandError | ||
if e.exit_code != 255 or attempts == 0: # pylint: disable=no-member | ||
raise | ||
log.warning("The operation failed with SSH Connection time out, retrying in 30 secs. Error: %s", e) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we log the actual stderr instead of "failed with SSH Connection time out,"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
9780951
to
4e68cf3
Compare
Description
retry ssh run in e2e tests
Issue #
PR information
Quality of Code and Contribution Guidelines