Remove cgroup files during deprovisioning #2790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maddieford
requested review from
narrieta,
ZhidongPeng and
nagworld9
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #2790 +/- ##
===========================================
+ Coverage 71.97% 72.01% +0.03%
===========================================
Files 103 104 +1
Lines 15692 15870 +178
Branches 2486 2273 -213
===========================================
+ Hits 11295 11429 +134
- Misses 3881 3916 +35
- Partials 516 525 +9
... and 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
narrieta
previously approved these changes
Mar 23, 2023
narrieta
previously approved these changes
Mar 23, 2023
nagworld9
reviewed
Mar 23, 2023
| # Get slices to remove | ||
| unit_file_install_path = systemd.get_unit_file_install_path() | ||
| log_collector_slice_path = os.path.join(unit_file_install_path, LOGCOLLECTOR_SLICE) | ||
| azure_slice_path = os.path.join(unit_file_install_path, AZURE_SLICE) |
There was a problem hiding this comment.
I wouldn't remove this file too because we are leaving azure.slice definition in service file in new agent versions. Otherwise, it may produce issues.
There was a problem hiding this comment.
can you update PR description too for future reference?
narrieta
approved these changes
Mar 23, 2023
nagworld9
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the following cgroup files during deprovisioning:
azure-walinuxagent-logcollector.slice
walinuxagent.service.d/10-Slice.conf
walinuxagent.service.d/11-CPUAccounting.conf
walinuxagent.service.d/12-CPUQuota.conf
walinuxagent.service.d/13-MemoryAccounting.conf
Description
Issue #
PR information
Quality of Code and Contribution Guidelines