-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove cgroup files during deprovisioning #2790
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2790 +/- ##
===========================================
+ Coverage 71.97% 72.01% +0.03%
===========================================
Files 103 104 +1
Lines 15692 15870 +178
Branches 2486 2273 -213
===========================================
+ Hits 11295 11429 +134
- Misses 3881 3916 +35
- Partials 516 525 +9
... and 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
# Get slices to remove | ||
unit_file_install_path = systemd.get_unit_file_install_path() | ||
log_collector_slice_path = os.path.join(unit_file_install_path, LOGCOLLECTOR_SLICE) | ||
azure_slice_path = os.path.join(unit_file_install_path, AZURE_SLICE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't remove this file too because we are leaving azure.slice definition in service file in new agent versions. Otherwise, it may produce issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you update PR description too for future reference?
Remove the following cgroup files during deprovisioning:
azure-walinuxagent-logcollector.slice
walinuxagent.service.d/10-Slice.conf
walinuxagent.service.d/11-CPUAccounting.conf
walinuxagent.service.d/12-CPUQuota.conf
walinuxagent.service.d/13-MemoryAccounting.conf
Description
Issue #
PR information
Quality of Code and Contribution Guidelines