Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Extensions.Enabled in tests #2892

Merged
merged 6 commits into from
Aug 8, 2023
Merged

Enable Extensions.Enabled in tests #2892

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1a6d5f5
enable Extensions.Enabled
nagworld9 Aug 4, 2023
7746695
address comment
nagworld9 Aug 8, 2023
778c2f7
address comment
nagworld9 Aug 8, 2023
a4dac8c
use script
nagworld9 Aug 8, 2023
b2f3b47
improve msg
nagworld9 Aug 8, 2023
f923f60
improve msg
nagworld9 Aug 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tests_e2e/orchestrator/scripts/install-agent
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,8 @@ sed -i 's/AutoUpdate.Enabled=n/AutoUpdate.Enabled=y/g' "$waagent_conf_path"
# By default GAUpdates flag set to True, so that agent go through update logic to look for new agents.
# But in e2e tests this flag needs to be off in test version 9.9.9.9 to stop the agent updates, so that our scenarios run on 9.9.9.9.
sed -i '$a Debug.DownloadNewAgents=n' "$waagent_conf_path"

# Some distros like debian disable extensions by default, so we need to enable them to verify agent extension scenarios
sed -i 's/Extensions.Enabled=n/Extensions.Enabled=y/g' "$waagent_conf_path"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's use the script we created to modify waagent.conf

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should log when extensions are initially disabled

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should do this only for Debian and fail setup if extensions are disabled on other distros... that way we have an alarm in our automation in case this happens on other distros

#
# Restart the service
#
Expand Down
Loading