Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup SUSE config #432

Merged
merged 2 commits into from
Nov 9, 2016
Merged

Conversation

bear454
Copy link
Contributor

@bear454 bear454 commented Sep 16, 2016

re: BSC#997475 - waagent.conf in python-azure-agent package should use ext4 for ephemeral disk filed by @szarkos

While correcting the SUSE config, a few other omissions were noted.

WRT to 1d4d383, this change is currently being made as part of image generation; moving to the config file reduces the number of times we need to touch /etc/waagent.conf.

@msftclas
Copy link

Hi @bear454, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@szarkos
Copy link
Contributor

szarkos commented Nov 8, 2016

Hi All,

What's holding up this commit? If it's the AutoUpdate.Enabled=n change then we could possible revert that part, but clean up the rest.

Steve

# Enable RDMA management and set up, should only be used in HPC images
# OS.EnableRDMA=y

# Enable or disable goal state processing auto-update, default is enabled
# AutoUpdate.Enabled=y
AutoUpdate.Enabled=n
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bear454 We need to leave AutoUpdate.Enabled set to true (aka "y"). It is best for Azure customers.

@brendandixon
Copy link
Contributor

@szarkos Just other things going on and have not looked. I agree with reverting the change to AutoUpdate.Enabled. Once that's done we can merge.

@bear454
Copy link
Contributor Author

bear454 commented Nov 9, 2016

Okay...

@brendandixon
Copy link
Contributor

@bear454 Looks good.

@brendandixon brendandixon added this to the v2.2.1 milestone Nov 9, 2016
@brendandixon brendandixon merged commit 958ad6e into Azure:master Nov 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants