Ignore InVMArtifactsProfile.OnHold once it becomes false (#481) #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hglkrijger
requested changes
Nov 15, 2016
| # If in_vm_artifacts_profile_blob does not exist, do not hold | ||
| if ext_conf and \ | ||
| ext_conf.in_vm_artifacts_profile_blob and not \ | ||
| ext_conf.in_vm_artifacts_profile_blob.isspace(): |
There was a problem hiding this comment.
should this be changed to the new function you just added?
| Silently remove file | ||
| """ | ||
| try: | ||
| os.remove(filepath) |
There was a problem hiding this comment.
we might want some verbose logging here for debugging purposes
| in_vm_artifacts_profile = self.protocol.get_in_vm_artifacts_profile() | ||
| if in_vm_artifacts_profile and \ | ||
| in_vm_artifacts_profile.is_extension_handlers_handling_on_hold(): | ||
| if self.protocol.is_ext_handling_on_hold(): |
There was a problem hiding this comment.
Does this method need to be implemented or stubbed out in the Azure Stack / metadata protocol as well?
| if not is_extension_handling_on_hold and not os.path.isfile(was_on_hold_ever_set_to_false): | ||
| # If extension handling is not on hold, create WAS_ON_HOLD_EVER_SET_TO_FALSE file | ||
| # Once on hold is set to false, WALA should never hold extension handling in the current VM | ||
| fileutil.write_file(was_on_hold_ever_set_to_false, "") |
There was a problem hiding this comment.
should probably add more logging throughout this method?
| def is_extension_handling_on_hold(self): | ||
| is_extension_handling_on_hold = False | ||
| ext_conf = self.ext_conf | ||
| was_on_hold_ever_set_to_false = os.path.join(conf.get_lib_dir(), WAS_ON_HOLD_EVER_SET_TO_FALSE) |
There was a problem hiding this comment.
Maybe just me, but this name confuses me, Can we pick something else?
|
Discussed offline, this is on hold so closing the PR for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InVMArtifactsProfile.OnHold is used to support overprovisioning feature of CRP VMSS. Thus, the flag is meaningful only at the very beginning of the VM lifecycle and once it becomes False, Agent should never put extension processing on hold. However, under certain circumstance like VM losing an outbound internet connection, the current Agent suffers from making the correct decision as it loses access to VMArtifactsProfile when internet is not available.
The PR is needed to resolve the issue.
After the PR, Agent makes the decision based on the following conditions: