Minor bug fixes #536
Merged
Minor bug fixes #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendandixon
reviewed
Jan 9, 2017
| secure = False | ||
| if secure_warning: | ||
| logger.warn("httplib is not built with ssl support") | ||
| secure_warning = False |
There was a problem hiding this comment.
@hglkrijger I can see you set it False here, but where does it ever achieve True?
There was a problem hiding this comment.
@hglkrijger Hmm, how did I miss that? :P
brendandixon
reviewed
Jan 9, 2017
| @@ -107,7 +107,8 @@ def parse_ext_status(ext_status, data): | |||
| if substatus_list is None: | |||
| return | |||
| for substatus in substatus_list: | |||
| ext_status.substatusList.append(parse_ext_substatus(substatus)) | |||
| if substatus is not None: | |||
There was a problem hiding this comment.
@hglkrijger Would a better check be to see if ext_status.substatuslist is a list (that is, check for vs. check absence)?
There was a problem hiding this comment.
The issue we see is that substatus is None, and the parse in line 111 fails.
There was a problem hiding this comment.
@hglkrijger I understand. But 111 needs a list...so why not check (if possible) that ext_status.substatusList is a list (vs. simply ensuring it's not None)?
There was a problem hiding this comment.
@hglkrijger Nevermind. Senility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @jinhyunr @brendandixon