-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address #769, #764, #761,#757, #754, #746, #740 #776
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, minor comments
from datetime import datetime | ||
from datetime import datetime, timedelta | ||
|
||
EVERY_DAY = timedelta(days=1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we avoid redefining these?
pkg_list = ExtHandlerPackageList() | ||
|
||
manifest = None | ||
for version_uri in ext_handler.versionUris: | ||
try: | ||
manifest, etag = self._get_data(version_uri.uri) | ||
logger.info("Successfully downloaded manifest") | ||
logger.verbose("Successfully downloaded manifest") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these may affect the BVTs, we'll see.
# use a configured proxy | ||
kwargs['chk_proxy'] = True | ||
# Default to use the configured HTTP proxy | ||
if not 'chk_proxy' in kwargs or kwargs['chk_proxy'] is None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this.
azurelinuxagent/ga/update.py
Outdated
@@ -287,6 +286,7 @@ def run(self): | |||
time.sleep(GOAL_STATE_INTERVAL) | |||
|
|||
except Exception as e: | |||
print(e) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yikes! Yup.
[#764] -- waagent -configuration-path:/path -start not take effect [#761] -- MetadataProtocol has no client object [#757] -- deprovision is executed even if input 'n' [#754] -- /etc/resolv.conf is removed if create a VM base on an specialized image [#746] -- Agent WALinuxAgent-2.2.12 is blacklisted - skipping download [#740] -- Duplicate logging on RHEL/CentOS Signed-off-by: Brendan Dixon <brendandixon@me.com>
[#769] -- HostGAPlugin requests should never go through proxy
[#764] -- waagent -configuration-path:/path -start not take effect
[#761] -- MetadataProtocol has no client object
[#757] -- deprovision is executed even if input 'n'
[#754] -- /etc/resolv.conf is removed if create a VM base on an specialized image
[#746] -- Agent WALinuxAgent-2.2.12 is blacklisted - skipping download
[#740] -- Duplicate logging on RHEL/CentOS
Signed-off-by: Brendan Dixon brendandixon@me.com