Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#801] -- Agent fails to clean-up PID files #813

Merged
merged 1 commit into from
Jul 25, 2017
Merged

[#801] -- Agent fails to clean-up PID files #813

merged 1 commit into from
Jul 25, 2017

Conversation

brendandixon
Copy link
Contributor

@brendandixon brendandixon commented Jul 24, 2017

[#801] -- Agent fails to clean-up PID files
[#811] -- Comments inline in /etc/waagent.conf cause config to not be read
[#812] -- Agent fails and isn't recoverable if an extension's log directory is not present anymore

Signed-off-by: Brendan Dixon brendandixon@me.com

Copy link
Member

@hglkrijger hglkrijger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

if os.path.isfile(ext_log_dir):
raise Exception("{0} is a file".format(ext_log_dir))
if not os.path.isdir(ext_log_dir):
os.mkdir(ext_log_dir)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might want to create the whole tree?

[#811] -- Comments inline in /etc/waagent.conf cause config to not be read
[#812] -- Agent fails and isn't recoverable if an extension's log directory is not present anymore

Signed-off-by: Brendan Dixon <brendandixon@me.com>
@brendandixon brendandixon merged commit 2bbe049 into Azure:master Jul 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants