This repository has been archived by the owner on Oct 12, 2023. It is now read-only.
Handle case sensitive id check #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aramase
commented
Jul 1, 2019
| @@ -65,7 +66,7 @@ func filter(ls *[]string, filter string) { | |||
| } | |||
|
|
|||
| for i, v := range *ls { | |||
| if v == filter { | |||
| if strings.EqualFold(v, filter) { | |||
There was a problem hiding this comment.
One thing to note - before the identity was never removed if it was manually created and the resourceID format was different in azure identity. With this change it'll be deleted even if the case is different in resourceID.
kkmsft
approved these changes
Jul 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
MIC fails when trying to compare same identity but with different cases for resource groups
resourceGroups|resourcegroupsin the resourceID format. This results in error when trying to assign the identity which already exists. This change will ensure we validate the identities case insensitively.Issue Fixed:
#269
Notes for Reviewers: