This repository has been archived by the owner on Oct 12, 2023. It is now read-only.
Fix assigned id deletion when no identity exists #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aramase
force-pushed
the
fix-failover-bug
branch
from
9a33f0b
to
d1a0827
Compare
kkmsft
reviewed
Jul 31, 2019
| @@ -105,6 +105,10 @@ func (i *vmIdentityInfo) RemoveUserIdentity(id string) error { | |||
| if i.info.Type == compute.ResourceIdentityTypeNone || i.info.Type == compute.ResourceIdentityTypeSystemAssigned { | |||
| i.info.IdentityIds = nil | |||
| } | |||
| // if the identityids is nil and identity type is not set, then set it to ResourceIdentityTypeNone | |||
| if i.info.IdentityIds == nil && i.info.Type == "" { | |||
There was a problem hiding this comment.
Thinking more here, shouldn't we just skip the call to cloud overall in this scenario ?
aramase
force-pushed
the
fix-failover-bug
branch
from
d1a0827
to
4a47bc6
Compare
Ran 15 of 16 Specs in 3024.197 seconds
SUCCESS! -- 15 Passed | 0 Failed | 0 Pending | 1 Skipped
--- PASS: TestAADPodIdentity (3024.20s)
PASS
ok github.com/Azure/aad-pod-identity/test/e2e 3024.220s |
aramase
changed the title
kkmsft
approved these changes
Aug 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
When the last underlying identity is deleted from the node, the deletion of assigned identity fails because the resource type is not set during the
CreateOrUpdatecall. This PR ensures when the identity list is nil, the resource type is set to None.Adds e2e test to valid the scenario.
Issue Fixed:
Fixes #313
Notes for Reviewers: