This repository has been archived by the owner on Oct 12, 2023. It is now read-only.
Fix the token backward compat in host based token fetching #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aramase
approved these changes
Aug 12, 2019
aramase
reviewed
Aug 12, 2019
kkmsft
changed the title
|
Ran 15 of 17 Specs in 3684.931 seconds |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
As aad-pod-identity moved to new adal libraries, the usage of older libraries had become incompatible (due to backward combat issues introduced with Azure/go-autorest#326). With the PR #306 backward compatibility was added in paths where applications fetch tokens. The host handler path which is used by kevvault flex volume also needs similar fixes. This PR fixes that path.
Issue Fixed:
#336
Notes for Reviewers:
Ran 15 of 17 Specs in 3684.931 seconds
SUCCESS! -- 15 Passed | 0 Failed | 0 Pending | 2 Skipped
--- PASS: TestAADPodIdentity (3684.93s)
PASS
ok github.com/Azure/aad-pod-identity/test/e2e 3684.958s