Fix namespaced multiple binding/identity handling and verbose logs #388
Conversation
Add more verbose logs for better debugging. In forcenamespaced configuration multiple bindings or identities could exists with the same name in different namespaces. The last binding which matched was used to create the assigned identity representing current state. This PR fixes the issue by using the right bindings and identities. The map used for handling of identities did not consider the namespace. This PR changes the key of the map to a combination of namespace and name of the identity.
|
Current test status: Summarizing 2 Failures: [Fail] Kubernetes cluster using aad-pod-identity [It] should not alter the user assigned identity on VM after AAD pod identity is created and deleted [Fail] Kubernetes cluster using aad-pod-identity [It] should create azureassignedidentities for 40 pods within ~2mins 30seconds Ran 19 of 19 Specs in 5018.288 seconds |
• [SLOW TEST:297.169 seconds]
Kubernetes cluster using aad-pod-identity
/Users/kkmsft/projects/aad-pod-identity/go/src/github.com/Azure/aad-pod-identity/test/e2e/aadpodidentity_test.go:111
should create azureassignedidentities for 40 pods within ~2mins 30seconds
/Users/kkmsft/projects/aad-pod-identity/go/src/github.com/Azure/aad-pod-identity/test/e2e/aadpodidentity_test.go:555
------------------------------
SSSSSSSSS
Tearing down the test suite environment...
$ kubectl delete -f template/_output/default-deployment.yaml --now --ignore-not-found
$ kubectl delete -f template/busyboxds.yaml
$ kubectl delete deploy --all
$ kubectl get nodes -ojson
# Removing system assigned identity from k8s-agentpool1-31275592-vmss...
# Removing system assigned identity from k8s-agentpool1-31275592-vmss...
# Removing system assigned identity from k8s-agentpool1-31275592-vmss...
Ran 1 of 19 Specs in 436.890 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 18 Skipped
PASS
```bash |
In forcenamespaced configuration multiple bindings or identities could exists with the same name in different namespaces. The last binding which matched was used to create the assigned identity representing current state. This PR fixes the issue by using the right bindings and identities.
The map used for handling of identities did not consider the namespace. This PR changes the key of the map to a combination of namespace and name of the identity.
Reason for Change:
Issue Fixed:
Notes for Reviewers: