Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

perf: Network Monitor v0.0.6 integration #912

Merged
merged 5 commits into from
Apr 1, 2019

Conversation

tamilmani1989
Copy link
Member

Reason for Change:

This PR addresses

  1. share telemetry socket with azure cni instead of having separate socket
  2. fix telemetry socket leaks in one of the error cases.

Issue Fixed:

Requirements:

Notes:

@CecileRobertMichon CecileRobertMichon added the needs-rebase Changes in the target branch require a `git rebase` and `git push -f` label Mar 29, 2019
@acs-bot acs-bot added size/M and removed size/S labels Mar 29, 2019
@jackfrancis
Copy link
Member

/azp run pr-e2e

@jackfrancis
Copy link
Member

lgtm pending E2E

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@CecileRobertMichon CecileRobertMichon removed the needs-rebase Changes in the target branch require a `git rebase` and `git push -f` label Mar 30, 2019
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented Mar 30, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, tamilmani1989

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Mar 30, 2019

Codecov Report

Merging #912 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #912   +/-   ##
=======================================
  Coverage   73.38%   73.38%           
=======================================
  Files         130      130           
  Lines       17678    17678           
=======================================
  Hits        12973    12973           
  Misses       4007     4007           
  Partials      698      698

@CecileRobertMichon
Copy link
Contributor

1.14 failure is known issue #919

@CecileRobertMichon CecileRobertMichon merged commit 57e4a41 into Azure:master Apr 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants