Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Insert calls to runtime.StartSpan in APIs #954

Merged
merged 14 commits into from
Jun 2, 2023
Merged

Insert calls to runtime.StartSpan in APIs #954

merged 14 commits into from
Jun 2, 2023

Conversation

jhendrixMSFT
Copy link
Member

This requries using named return values in APIs so that the deferred call to endSpan() can capture the error.

@jhendrixMSFT
Copy link
Member Author

Fixes #501

@jhendrixMSFT jhendrixMSFT mentioned this pull request May 9, 2023
Closed
@jhendrixMSFT
Insert calls to runtime.StartSpan in APIs
488e7ca 
This requries using named return values in APIs so that the deferred
call to endSpan() can capture the error.
@jhendrixMSFT
remove references to jaeger and azotel
a106ac7
@jhendrixMSFT
make span generation opt-in with undocumented switch inject-spans
2bba2b1
chlowell
chlowell reviewed May 30, 2023
View reviewed changes
Copy link
Member

@chlowell chlowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this repo the best place for a simple end-to-end test verifying a generated client started and ended a span as expected? (I guess that could go in a management plane test suite instead)

packages/autorest.go/src/generator/operations.ts Outdated Show resolved Hide resolved
@jhendrixMSFT
Copy link
Member Author

Will add tests to verify spans are properly ended.

@jhendrixMSFT
removed use of named return values
06ce21b 
updated autorest go.mod to use the beta of azcore
generate some content without --inject-spans to ensure it works
@jhendrixMSFT jhendrixMSFT merged commit 9b902e7 into Azure:main Jun 2, 2023
@jhendrixMSFT jhendrixMSFT deleted the tracing_codegen branch June 2, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chlowell chlowell chlowell approved these changes

@RickWinter RickWinter Awaiting requested review from RickWinter RickWinter is a code owner

@ArcturusZhang ArcturusZhang Awaiting requested review from ArcturusZhang ArcturusZhang is a code owner

@lirenhe lirenhe Awaiting requested review from lirenhe lirenhe is a code owner

@tadelesh tadelesh Awaiting requested review from tadelesh tadelesh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhendrixMSFT @chlowell