do not add api version validation decorator to overload function (#2634)

* do not add api version validation decorator to overload function * changelog
Azure · Jun 14, 2024 · 369124f · 369124f
1 parent b6c5aaf
commit 369124f
Show file tree

Hide file tree

Showing 13 changed files with 159 additions and 180 deletions.
diff --git a/.chronus/changes/add-usage-2024-5-11-16-39-4.md b/.chronus/changes/add-usage-2024-5-11-16-39-4.md
@@ -5,4 +5,4 @@ packages:
   - "@azure-tools/typespec-python"
 ---
 
-Remove unnecessary doc for model which is only used for output
+Remove unnecessary doc for model which is only used for output
diff --git a/.chronus/changes/added_overload-2024-5-14-15-43-45.md b/.chronus/changes/added_overload-2024-5-14-15-43-45.md
@@ -0,0 +1,7 @@
+---
+changeKind: fix
+packages:
+  - "@autorest/python"
+---
+
+do not add api version validation decorator to overload function
diff --git a/.chronus/changes/deserialization-fix-2024-4-24-16-48-41.md b/.chronus/changes/deserialization-fix-2024-4-24-16-48-41.md
@@ -5,4 +5,4 @@ packages:
   - "@azure-tools/typespec-python"
 ---
 
-Fix deserialization error for lro when return type has discriminator and succeed in initial response
+Fix deserialization error for lro when return type has discriminator and succeed in initial response
diff --git a/.chronus/changes/fix_models_only-2024-5-11-21-50-18.md b/.chronus/changes/fix_models_only-2024-5-11-21-50-18.md
@@ -4,4 +4,4 @@ packages:
   - "@autorest/python"
 ---
 
-generate sdks without operations
+generate sdks without operations
diff --git a/.chronus/changes/switch_to_rest-2024-4-30-12-59-16.md b/.chronus/changes/switch_to_rest-2024-4-30-12-59-16.md
@@ -4,4 +4,4 @@ packages:
   - "@autorest/python"
 ---
 
-remove support for deprecated azure.core.pipeline.transport requests and responses
+remove support for deprecated azure.core.pipeline.transport requests and responses
diff --git a/.chronus/changes/typing-self-2024-5-6-13-0-58.md b/.chronus/changes/typing-self-2024-5-6-13-0-58.md
@@ -5,4 +5,4 @@ packages:
   - "@azure-tools/typespec-python"
 ---
 
-Change return type of `__aenter__/__enter__` to `Self`
+Change return type of `__aenter__/__enter__` to `Self`
diff --git a/package.json b/package.json
@@ -36,7 +36,7 @@
   "devDependencies": {
     "@azure-tools/cadl-ranch": "~0.12.7",
     "@actions/github": "6.0.0",
-    "@chronus/chronus": "^0.10.1",
+    "@chronus/chronus": "^0.10.2",
     "@chronus/github": "^0.3.2",
     "@typespec/prettier-plugin-typespec": "~0.55.0",
     "autorest": "3.6.3",

diff --git a/packages/autorest.python/autorest/codegen/serializers/builder_serializer.py b/packages/autorest.python/autorest/codegen/serializers/builder_serializer.py
@@ -189,6 +189,8 @@ def _get_json_response_template_to_status_codes(
 
 
 def _api_version_validation(builder: OperationType) -> str:
+    if builder.is_overload:
+        return ""
     retval: List[str] = []
     if builder.added_on:
         retval.append(f'    method_added_on="{builder.added_on}",')

diff --git a/...thon/test/azure/generated/versioning-added/versioning/added/aio/operations/_operations.py b/...thon/test/azure/generated/versioning-added/versioning/added/aio/operations/_operations.py
@@ -61,10 +61,6 @@ def __init__(self, *args, **kwargs) -> None:
         self._deserialize = input_args.pop(0) if input_args else kwargs.pop("deserializer")
 
     @overload
-    @api_version_validation(
-        method_added_on="v2",
-        params_added_on={"v2": ["content_type", "accept"]},
-    )
     async def v2_in_interface(
         self, body: _models.ModelV2, *, content_type: str = "application/json", **kwargs: Any
     ) -> _models.ModelV2:
@@ -98,10 +94,6 @@ async def v2_in_interface(
         """
 
     @overload
-    @api_version_validation(
-        method_added_on="v2",
-        params_added_on={"v2": ["content_type", "accept"]},
-    )
     async def v2_in_interface(
         self, body: JSON, *, content_type: str = "application/json", **kwargs: Any
     ) -> _models.ModelV2:
@@ -128,10 +120,6 @@ async def v2_in_interface(
         """
 
     @overload
-    @api_version_validation(
-        method_added_on="v2",
-        params_added_on={"v2": ["content_type", "accept"]},
-    )
     async def v2_in_interface(
         self, body: IO[bytes], *, content_type: str = "application/json", **kwargs: Any
     ) -> _models.ModelV2:
@@ -248,9 +236,6 @@ async def v2_in_interface(self, body: Union[_models.ModelV2, JSON, IO[bytes]], *
 class AddedClientOperationsMixin(AddedClientMixinABC):
 
     @overload
-    @api_version_validation(
-        params_added_on={"v2": ["header_v2"]},
-    )
     async def v1(
         self, body: _models.ModelV1, *, header_v2: str, content_type: str = "application/json", **kwargs: Any
     ) -> _models.ModelV1:
@@ -288,9 +273,6 @@ async def v1(
         """
 
     @overload
-    @api_version_validation(
-        params_added_on={"v2": ["header_v2"]},
-    )
     async def v1(
         self, body: JSON, *, header_v2: str, content_type: str = "application/json", **kwargs: Any
     ) -> _models.ModelV1:
@@ -320,9 +302,6 @@ async def v1(
         """
 
     @overload
-    @api_version_validation(
-        params_added_on={"v2": ["header_v2"]},
-    )
     async def v1(
         self, body: IO[bytes], *, header_v2: str, content_type: str = "application/json", **kwargs: Any
     ) -> _models.ModelV1:
@@ -445,10 +424,6 @@ async def v1(
         return deserialized  # type: ignore
 
     @overload
-    @api_version_validation(
-        method_added_on="v2",
-        params_added_on={"v2": ["content_type", "accept"]},
-    )
     async def v2(
         self, body: _models.ModelV2, *, content_type: str = "application/json", **kwargs: Any
     ) -> _models.ModelV2:
@@ -482,10 +457,6 @@ async def v2(
         """
 
     @overload
-    @api_version_validation(
-        method_added_on="v2",
-        params_added_on={"v2": ["content_type", "accept"]},
-    )
     async def v2(self, body: JSON, *, content_type: str = "application/json", **kwargs: Any) -> _models.ModelV2:
         """v2.
 
@@ -510,10 +481,6 @@ async def v2(self, body: JSON, *, content_type: str = "application/json", **kwar
         """
 
     @overload
-    @api_version_validation(
-        method_added_on="v2",
-        params_added_on={"v2": ["content_type", "accept"]},
-    )
     async def v2(self, body: IO[bytes], *, content_type: str = "application/json", **kwargs: Any) -> _models.ModelV2:
         """v2.
 

diff --git a/...c-python/test/azure/generated/versioning-added/versioning/added/operations/_operations.py b/...c-python/test/azure/generated/versioning-added/versioning/added/operations/_operations.py
@@ -112,10 +112,6 @@ def __init__(self, *args, **kwargs):
         self._deserialize = input_args.pop(0) if input_args else kwargs.pop("deserializer")
 
     @overload
-    @api_version_validation(
-        method_added_on="v2",
-        params_added_on={"v2": ["content_type", "accept"]},
-    )
     def v2_in_interface(
         self, body: _models.ModelV2, *, content_type: str = "application/json", **kwargs: Any
     ) -> _models.ModelV2:
@@ -149,10 +145,6 @@ def v2_in_interface(
         """
 
     @overload
-    @api_version_validation(
-        method_added_on="v2",
-        params_added_on={"v2": ["content_type", "accept"]},
-    )
     def v2_in_interface(self, body: JSON, *, content_type: str = "application/json", **kwargs: Any) -> _models.ModelV2:
         """v2_in_interface.
 
@@ -177,10 +169,6 @@ def v2_in_interface(self, body: JSON, *, content_type: str = "application/json",
         """
 
     @overload
-    @api_version_validation(
-        method_added_on="v2",
-        params_added_on={"v2": ["content_type", "accept"]},
-    )
     def v2_in_interface(
         self, body: IO[bytes], *, content_type: str = "application/json", **kwargs: Any
     ) -> _models.ModelV2:
@@ -297,9 +285,6 @@ def v2_in_interface(self, body: Union[_models.ModelV2, JSON, IO[bytes]], **kwarg
 class AddedClientOperationsMixin(AddedClientMixinABC):
 
     @overload
-    @api_version_validation(
-        params_added_on={"v2": ["header_v2"]},
-    )
     def v1(
         self, body: _models.ModelV1, *, header_v2: str, content_type: str = "application/json", **kwargs: Any
     ) -> _models.ModelV1:
@@ -337,9 +322,6 @@ def v1(
         """
 
     @overload
-    @api_version_validation(
-        params_added_on={"v2": ["header_v2"]},
-    )
     def v1(
         self, body: JSON, *, header_v2: str, content_type: str = "application/json", **kwargs: Any
     ) -> _models.ModelV1:
@@ -369,9 +351,6 @@ def v1(
         """
 
     @overload
-    @api_version_validation(
-        params_added_on={"v2": ["header_v2"]},
-    )
     def v1(
         self, body: IO[bytes], *, header_v2: str, content_type: str = "application/json", **kwargs: Any
     ) -> _models.ModelV1:
@@ -492,10 +471,6 @@ def v1(self, body: Union[_models.ModelV1, JSON, IO[bytes]], *, header_v2: str, *
         return deserialized  # type: ignore
 
     @overload
-    @api_version_validation(
-        method_added_on="v2",
-        params_added_on={"v2": ["content_type", "accept"]},
-    )
     def v2(self, body: _models.ModelV2, *, content_type: str = "application/json", **kwargs: Any) -> _models.ModelV2:
         """v2.
 
@@ -527,10 +502,6 @@ def v2(self, body: _models.ModelV2, *, content_type: str = "application/json", *
         """
 
     @overload
-    @api_version_validation(
-        method_added_on="v2",
-        params_added_on={"v2": ["content_type", "accept"]},
-    )
     def v2(self, body: JSON, *, content_type: str = "application/json", **kwargs: Any) -> _models.ModelV2:
         """v2.
 
@@ -555,10 +526,6 @@ def v2(self, body: JSON, *, content_type: str = "application/json", **kwargs: An
         """
 
     @overload
-    @api_version_validation(
-        method_added_on="v2",
-        params_added_on={"v2": ["content_type", "accept"]},
-    )
     def v2(self, body: IO[bytes], *, content_type: str = "application/json", **kwargs: Any) -> _models.ModelV2:
         """v2.
 

diff --git a/.../test/unbranded/generated/versioning-added/versioning/added/aio/operations/_operations.py b/.../test/unbranded/generated/versioning-added/versioning/added/aio/operations/_operations.py
@@ -60,10 +60,6 @@ def __init__(self, *args, **kwargs) -> None:
         self._deserialize = input_args.pop(0) if input_args else kwargs.pop("deserializer")
 
     @overload
-    @api_version_validation(
-        method_added_on="v2",
-        params_added_on={"v2": ["content_type", "accept"]},
-    )
     async def v2_in_interface(
         self, body: _models.ModelV2, *, content_type: str = "application/json", **kwargs: Any
     ) -> _models.ModelV2:
@@ -97,10 +93,6 @@ async def v2_in_interface(
         """
 
     @overload
-    @api_version_validation(
-        method_added_on="v2",
-        params_added_on={"v2": ["content_type", "accept"]},
-    )
     async def v2_in_interface(
         self, body: JSON, *, content_type: str = "application/json", **kwargs: Any
     ) -> _models.ModelV2:
@@ -127,10 +119,6 @@ async def v2_in_interface(
         """
 
     @overload
-    @api_version_validation(
-        method_added_on="v2",
-        params_added_on={"v2": ["content_type", "accept"]},
-    )
     async def v2_in_interface(
         self, body: IO[bytes], *, content_type: str = "application/json", **kwargs: Any
     ) -> _models.ModelV2:
@@ -246,9 +234,6 @@ async def v2_in_interface(self, body: Union[_models.ModelV2, JSON, IO[bytes]], *
 class AddedClientOperationsMixin(AddedClientMixinABC):
 
     @overload
-    @api_version_validation(
-        params_added_on={"v2": ["header_v2"]},
-    )
     async def v1(
         self, body: _models.ModelV1, *, header_v2: str, content_type: str = "application/json", **kwargs: Any
     ) -> _models.ModelV1:
@@ -286,9 +271,6 @@ async def v1(
         """
 
     @overload
-    @api_version_validation(
-        params_added_on={"v2": ["header_v2"]},
-    )
     async def v1(
         self, body: JSON, *, header_v2: str, content_type: str = "application/json", **kwargs: Any
     ) -> _models.ModelV1:
@@ -318,9 +300,6 @@ async def v1(
         """
 
     @overload
-    @api_version_validation(
-        params_added_on={"v2": ["header_v2"]},
-    )
     async def v1(
         self, body: IO[bytes], *, header_v2: str, content_type: str = "application/json", **kwargs: Any
     ) -> _models.ModelV1:
@@ -442,10 +421,6 @@ async def v1(
         return deserialized  # type: ignore
 
     @overload
-    @api_version_validation(
-        method_added_on="v2",
-        params_added_on={"v2": ["content_type", "accept"]},
-    )
     async def v2(
         self, body: _models.ModelV2, *, content_type: str = "application/json", **kwargs: Any
     ) -> _models.ModelV2:
@@ -479,10 +454,6 @@ async def v2(
         """
 
     @overload
-    @api_version_validation(
-        method_added_on="v2",
-        params_added_on={"v2": ["content_type", "accept"]},
-    )
     async def v2(self, body: JSON, *, content_type: str = "application/json", **kwargs: Any) -> _models.ModelV2:
         """v2.
 
@@ -507,10 +478,6 @@ async def v2(self, body: JSON, *, content_type: str = "application/json", **kwar
         """
 
     @overload
-    @api_version_validation(
-        method_added_on="v2",
-        params_added_on={"v2": ["content_type", "accept"]},
-    )
     async def v2(self, body: IO[bytes], *, content_type: str = "application/json", **kwargs: Any) -> _models.ModelV2:
         """v2.