Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deepcoy for dpg model #2523

Merged
merged 7 commits into from
Apr 16, 2024
Merged

Remove deepcoy for dpg model #2523

merged 7 commits into from
Apr 16, 2024

Conversation

msyyc
Copy link
Member

@msyyc msyyc commented Apr 16, 2024 •
edited
Loading

fixes #2516
The PR includes:

  • remove deepcopy for dpg model init
  • add warning in docstring for users
  • add test

@msyyc msyyc marked this pull request as ready for review April 16, 2024 06:11
iscai-msft
iscai-msft approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@iscai-msft iscai-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, we just don't need to have comments about deepcopy, users honestly shouldn't feel that there's any difference

@iscai-msft iscai-msft enabled auto-merge (squash) April 16, 2024 21:34
@iscai-msft iscai-msft merged commit 593b7b2 into main Apr 16, 2024
14 checks passed
@iscai-msft iscai-msft deleted the remove-deepcoy-dev2 branch April 16, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iscai-msft iscai-msft iscai-msft approved these changes

@tadelesh tadelesh Awaiting requested review from tadelesh tadelesh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't assign a file descriptor to a property in DPG model
2 participants
@msyyc @iscai-msft