-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deserialization error for LRO which has discriminator #2589
Closed
Closed
Changes from 40 commits
Commits
Show all changes
52 commits
Select commit
Hold shift + click to select a range
4c12c62
code
msyyc 49ab757
fix for legacy test
msyyc 3c22f8e
inv and black
msyyc 7adc1c8
fix mypy
msyyc ca98be8
fix pyright error
msyyc e142d48
fix pylint
msyyc 1857677
inv
msyyc dccdd16
update
msyyc c97c28c
review
msyyc 2eea3a4
fix
msyyc a718d6a
fix
msyyc ebf0e16
Fix test
msyyc 738caab
fix multiapi test
msyyc 76c8d03
disable deserialize for all initial operation
msyyc d163f3d
review
msyyc 133bf7b
inv
msyyc f830afe
Merge branch 'main' of https://github.com/Azure/autorest.python into …
msyyc f464d47
update changelog
msyyc 0647135
inv
msyyc c0f0610
Merge branch 'deserialization-fix' of https://github.com/Azure/autore…
msyyc 148e934
inv
msyyc 52c13db
Merge branch 'main' into deserialization-fix
msyyc 8b7f073
Merge branch 'main' into deserialization-fix
msyyc 24d19a1
force initial operation to return stream
fa2c5ce
revert extra changes in builder_serializer
41f1d09
regen
3a04d08
regen lropaging
c92b238
regen with load_body for aiohttp
f71903c
fix
msyyc 49d85c3
inv
msyyc 1602dc1
use pipeline_response.http_response for legacy
msyyc 015d844
fix test
msyyc bcbc2d3
inv
msyyc 44017d5
Merge branch 'main' of https://github.com/Azure/autorest.python into …
f7e5be6
Merge branch 'deserialization-fix' of https://github.com/Azure/autore…
f0eae62
read in response
d8ef34f
inv
msyyc b086c62
fix multiapi test
msyyc 066eb98
inv
msyyc cfb50f5
fix pyright
msyyc df5cf4c
simplify code
cfe3dbd
generate
e805530
regen
eb9250a
regenerate
f6577fb
black
d70e0e9
Merge branch 'main' of https://github.com/Azure/autorest.python into …
d71c77b
regen to revert changes
a3f8f22
revert changes
91d8643
regen
6681433
Merge branch 'main' of https://github.com/Azure/autorest.python into …
01b89e8
regen
c0e2522
revert tasks change
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
--- | ||
changeKind: fix | ||
packages: | ||
- "@autorest/python" | ||
- "@azure-tools/typespec-python" | ||
--- | ||
|
||
Fix deserialization error for lro when return type has discriminator and succeed in initial response |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can always call read, regardless of stream or not
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is very strange to judge _stream when its value is
True
, so I think it is better to keep the logic.