Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change return type of __aenter__/__enter__ to Self #2620

Merged
merged 5 commits into from
Jun 7, 2024
Merged

Change return type of __aenter__/__enter__ to Self #2620

merged 5 commits into from
Jun 7, 2024

Conversation

msyyc
Copy link
Member

@msyyc msyyc commented Jun 6, 2024

fixes #2619

@msyyc msyyc changed the title Typing self Change return type of __aenter__/__enter__ to Self Jun 6, 2024
@msyyc msyyc requested a review from lmazuel June 7, 2024 02:54
@lmazuel lmazuel merged commit d53efe1 into main Jun 7, 2024
15 checks passed
@lmazuel lmazuel deleted the typing-self branch June 7, 2024 16:43
@msyyc msyyc mentioned this pull request Jun 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmazuel lmazuel lmazuel approved these changes

@iscai-msft iscai-msft Awaiting requested review from iscai-msft iscai-msft is a code owner

@tadelesh tadelesh Awaiting requested review from tadelesh tadelesh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

__aenter__/__enter__ should be typed as returning typing.Self.
3 participants
@msyyc @lmazuel @iscai-msft