Issues #7: CADL Generated Code Issue in EventGrid SDK

[sarangan12]

While working on the EventGrid SDK, generated from the CADL files, I have noticed the following.

We have the following CADL:

@doc("The result of the Acknowledge operation.")
model AcknowledgeResult {
    @doc("Array of LockToken values for failed cloud events. Each LockToken includes the lock token value along with the related error information (namely, the error code and description).")
    failedLockTokens: FailedLockToken[];

    @doc("Array of lock tokens values for the successfully acknowledged cloud events.")
    succeededLockTokens: string[];
  }

@doc("Acknowledge Cloud Events Body")
  model AcknowledgeCloudEventsBody {
    @doc("content type")
    @header("content-type")
    contentType: "application/json; charset=utf-8";

    @doc("Topic Name.")
    @path
    topicName: string;

    @doc("Event Subscription Name.")
    @path
    eventSubscriptionName: string;

    @doc("AcknowledgeOptions.")
    @body
    lockTokens: AcknowledgeOptions;
  }

@doc("Acknowledge batch of Cloud Events. The server responds with an HTTP 200 status code if at least one event is successfully acknowledged. The response body will include the set of successfully acknowledged lockTokens, along with other failed lockTokens with their corresponding error information. Successfully acknowledged events will no longer be available to any consumer.")

  @route("/topics/{topicName}/eventsubscriptions/{eventSubscriptionName}:acknowledge")
  @post op AcknowledgeCloudEvents is Azure.Core.RpcOperation<AcknowledgeCloudEventsBody, AcknowledgeResult>;

With the above CADL, the generated code has the following snippet:

return {
    failedLockTokens: (result.body["failedLockTokens"] ?? []).map((p) => ({
      lockToken: p["lockToken"],
      errorCode: p["errorCode"],
      errorDescription: p["errorDescription"],
    })),
    succeededLockTokens: result.body["succeededLockTokens"],
  };

Now, this causes the build error at result.body["failedLockTokens"]. Now the problem is I was able to get this error only when I use certain versions of packages to generate the SDK. I coordinated with Jose and used the following config:

"@azure-tools/rlc-common": "https://bit.ly/3Bj3aHb",
"@azure-tools/typespec-ts": "https://bit.ly/3VVKUNH",
"@typespec/compiler": "0.43.0",    
"@typespec/http": "0.43.1",
"@typespec/rest": "0.43.0",
"@typespec/openapi": "0.43.0",
"@typespec/versioning": "0.43.0",
"@azure-tools/typespec-azure-core": "0.29.0",
"@azure-tools/typespec-autorest": "0.29.0",
"@azure-tools/typespec-client-generator-core": "0.29.0",
"@typespec/openapi3": "0.43.0",
"@typespec/prettier-plugin-typespec": "0.43.0",
"prettier": "2.7.1"

With the above configuration, the error is not reported. But, If I use the latest, I can see the error happening. So, please verify the issue with the latest version and ensure that the error does not happen

[sarangan12]

Input file that can be used for testing: https://github.com/Azure/azure-rest-api-specs/blob/feature/eventgrid/typespec/specification/eventgrid/Azure.Messaging.EventGrid/main.tsp