remove default value in Modular #1977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiaozha
commented
Aug 18, 2023
Comment on lines
-521
to
-523
| return `"${param.restApiName}": options.${ | ||
| param.clientName | ||
| } ?? ${getQuotedValue(param)}`; |
There was a problem hiding this comment.
the question mark change is because of we now using getOptional which used to be getOptionalWithoutDefault and for OpenAI's case, they have a default value, they previously go into getOptionalWithDefault function.
There was a problem hiding this comment.
Compared with all the places that is using options to build the request body, this is the only places that doesn't have a question mark.
As options by literal means this parameter is optional, we should keep options?. no matter if it has a default value or not. Besides, even if it does have a default value. options?. won't report any errors.
qiaozha
commented
Aug 18, 2023
| @@ -456,7 +456,7 @@ export function _beginAzureBatchImageGenerationSend( | |||
| ...operationOptionsToRequestParameters(options), | |||
| body: { | |||
| prompt: prompt, | |||
| n: options.n ?? 1, | |||
| n: options?.n, | |||
There was a problem hiding this comment.
This is the change about question mark
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for comment #1975 (comment)