Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v6] Add Smoke Test + Fix parameter name #630

Merged
merged 2 commits into from
Apr 29, 2020
Merged

Conversation

joheredi
Copy link
Member

  • Add script for Smoke Testing supported sdks

    • Smoke test consists on Generating the sdk from a Readme.md and building without errors
    • Allow passing slice and size to smoke-test to be able to split smoke testing in chunks when the list of readmes grow.
  • Fix for parameter names, we were using serializedNames instead of the name already processed by prenamer

@joheredi joheredi requested review from daviwil and chradek April 28, 2020 20:31
Copy link
Contributor

@daviwil daviwil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Keeping a list of specs to run like that is a good idea since you'll want to pull some from different branches on the specs repo (or forks). I probably should have done that for the benchmarking script.

src/transforms/parameterTransforms.ts Outdated Show resolved Hide resolved
@joheredi joheredi merged commit 22606e9 into Azure:v6 Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants