Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add azure-search-openai-demo-java template #193

Closed
wants to merge 0 commits into from

Conversation

dantelmomsft
Copy link
Member

Please fill out this template! There are three different types of contributions, feel free to delete the checklists that are not applicable to your contribution type.

If you are submitting a new azd template to the gallery

Fill this out if you want your template to be added to the awesome-azd gallery!

Your template repository

Place your template repository link here:
https://github.com/Azure-Samples/azure-search-openai-demo-java

  • Added an entry to https://github.com/Azure/awesome-azd/blob/main/website/src/data/users.tsx that includes:

    • Template title - A short title that reflects the local application stack that someone could use to get their application on Azure (e.g. "Containerized React Web App with Java API and MongoDB")
    • Description - 1-2 sentence description of the architecture (e.g. Azure services) or solution that is defined by the template.
    • Architecture Diagram or Application Screenshot - Used as display image for gallery card. The image should include all services and their connections (example). You should add the image to the website/src/data/images/.
    • Link to Author's GitHub or other relevant website - Used for attribution
    • Author's Name - Name to credit on the gallery card
    • Link to template source - Link to the template GitHub repo
    • Tags - One or more tags representing the template. Provide at least 1 tag for programming language used and at least 1 tag for Azure services integrated. Also tag the IaC provider (Bicep or Terraform). If you don't see a relevant tag for your template? Feel free to add one!
  • In the PR comment, if you can also add a link to the PR where you made your repo azd compatible this will allow us to provide feedback on your template and speed up the review process.

If you are submitting a resource to be added to the awesome-azd README:

  • Name of resource
  • Resource author - who created this resource? (so we can credit them!)
  • What section should this resource be included in? -Is the resource an article? A video? Something else?

@hemarina
Copy link
Contributor

@v-xuto Could you test this template?

@v-xuto
Copy link
Member

v-xuto commented Sep 21, 2023

@v-xuto Could you test this template?

Sure. We will start test this template.

@dantelmomsft
Copy link
Member Author

dantelmomsft commented Oct 3, 2023

All issues are closed.
The only one open Azure-Samples/azure-search-openai-demo-java#7 is not reproducible. app CI pipeline is actually working.
@v-xuto @hemarina let me know how I can help to move this forward

@dantelmomsft dantelmomsft removed their assignment Oct 3, 2023
website/src/data/tags.tsx Outdated Show resolved Hide resolved
website/static/templates.json Outdated Show resolved Hide resolved
@dantelmomsft
Copy link
Member Author

All Issues are closed

@@ -6,7 +6,8 @@
"author": "Davide Antelmo",
"source": "https://github.com/Azure-Samples/azure-search-openai-demo-java",
"tags": [
"featured",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this repo has also been reviewed by Java dev eng team: Bruno Borges and John Oliver. It's going to be presented at Ignite. You might consider to review tags and set it as featured.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dantelmomsft when we updated awesome-azd's ui last week, we also made some changes to our tags-- one change being that 'featured' is no longer a tag.

Since the template is housed in Azure-Samples, was reviewed by Java dev eng team, and is going to be presented at Ignite, you could consider changing the "community" tag to "msft".

@dantelmomsft
Copy link
Member Author

dantelmomsft commented Oct 12, 2023

sorry I've wrongly closed this PR. please refer to the new one #218

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants