Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New AZD Project Template - Azure Serverless App with Angular and MSAL #412

Merged
merged 5 commits into from
Jul 16, 2024

Conversation

ryanninodizon
Copy link
Contributor

This template project is built using Angular 17-Standalone, Azure Functions, CosmosDB, and APIM, integrated with MSAL (Microsoft Authentication Library) for authentication and authorization. It aims to be a helpful starting point for anyone exploring serverless development and the Microsoft Identity platform.

@ryanninodizon
Copy link
Contributor Author

@microsoft-github-policy-service agree

@hemarina
Copy link
Contributor

hemarina commented Jul 5, 2024

@v-xuto Could you test this template please?

@v-xuto
Copy link
Member

v-xuto commented Jul 8, 2024

@ryanninodizon It is recommended to add how to use azd to deploy this project in ReadMe, like this todo template.

@ryanninodizon
Copy link
Contributor Author

@ryanninodizon It is recommended to add how to use azd to deploy this project in ReadMe, like this todo template.

@v-xuto thank you for your response. The ReadMe is now updated, please check it again: https://github.com/ryanninodizon/AzureServerlessApp-with-auth-for-dotnet-angular/blob/main/README.md

Thank you and have a nice day.

@v-xuto
Copy link
Member

v-xuto commented Jul 9, 2024

@hemarina, @ryanninodizon We have finished this template test, and we filed one issues. Please review.

@ryanninodizon
Copy link
Contributor Author

@v-xuto thank you so much for filing an issue. There error should be resolved now. see info below. Thanks again and have a nice day.

Copy link
Contributor

@hemarina hemarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for contributing templates. Just have some small comments.

website/static/templates.json Outdated Show resolved Hide resolved
website/static/templates.json Outdated Show resolved Hide resolved
website/static/templates.json Outdated Show resolved Hide resolved
website/static/templates.json Show resolved Hide resolved
ryanninodizon and others added 3 commits July 12, 2024 07:12
Co-authored-by: hemarina <104857065+hemarina@users.noreply.github.com>
@ryanninodizon
Copy link
Contributor Author

Thank you very much for contributing templates. Just have some small comments.

Thanks @hemarina for the review! I've updated all your suggestions.

@v-xuto
Copy link
Member

v-xuto commented Jul 12, 2024

@hemarina, @ryanninodizon Currently, we cannot verify whether issue1 has been fixed. Due to some issues with the appinsights service, we are unable to deploy this template successfully. Wait for the resource application insights to be created normally, we will retest.

@ryanninodizon
Copy link
Contributor Author

ryanninodizon commented Jul 12, 2024

@v-xuto thank you so much for your quick response. This is noted.
Have a nice day.

@v-xuto
Copy link
Member

v-xuto commented Jul 12, 2024

@hemarina Issue1 has been fixed. There are currently no issues with this template. Please review.

Copy link
Contributor

@hemarina hemarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your changes! This template will be synced on our weekly release day 7/17. If you prefer to have it live early, let us know and we will release by requests.

@hemarina hemarina merged commit 0a08ae9 into Azure:main Jul 16, 2024
2 checks passed
@ryanninodizon
Copy link
Contributor Author

@hemarina thank you so much for adding/merging my template. Have a nice day.

@ryanninodizon ryanninodizon deleted the new_template branch July 17, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants