Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new Azure Functions templates #449

Merged
merged 6 commits into from
Oct 21, 2024
Merged

Add new Azure Functions templates #449

merged 6 commits into from
Oct 21, 2024

Conversation

BigMorty
Copy link
Member

@BigMorty BigMorty commented Oct 10, 2024 •
edited
Loading

Please fill out this template! There are three different types of contributions, feel free to delete the checklists that are not applicable to your contribution type.

If you are submitting a new azd template to the gallery

Fill this out if you want your template to be added to the awesome-azd gallery!

Your template repository

Place your template repository link here:
https://github.com/Azure-Samples/functions-quickstart-dotnet-azd
https://github.com/Azure-Samples/functions-quickstart-python-http-azd
https://github.com/Azure-Samples/functions-quickstart-javascript-azd
https://github.com/Azure-Samples/functions-quickstart-typescript-azd
https://github.com/Azure-Samples/azure-functions-java-flex-consumption-azd
https://github.com/Azure-Samples/functions-quickstart-powershell-azd

  • Added an entry to https://github.com/Azure/awesome-azd/website/static/templates.json that includes:

    • Template title - A short title that reflects the local application stack that someone could use to get their application on Azure (e.g. "Containerized React Web App with Java API and MongoDB")

    • Description - 1-2 sentence description of the architecture (e.g. Azure services) or solution that is defined by the template.

    • Architecture Diagram or Application Screenshot - The image should include all services and their connections (example). You should add the image to the website/src/data/images/.

    • Link to Author's GitHub or other relevant website - Used for attribution

    • Author's Name - Name to credit on the gallery card

    • Link to template source - Link to the template GitHub repo

    • Tags - Specify tags to represent the template. If you don't see a relevant tag for your template? Feel free to add one!

      Required tags:

      • Tag your template as Micrsoft-authored ("msft") or Community-authored ("community")
      • Tag the IaC provider ("bicep" or "terraform")
      • At least 1 tag for programming language used
      • At least 1 tag for Azure services integrated
      • Add the "new" tag for any newly authored templates

  • In the PR comment, if you can also add a link to the PR where you made your repo azd compatible this will allow us to provide feedback on your template and speed up the review process.

  • If the template is Microsoft-authored, we encourage you to also publish it to learn.microsoft.com/samples.

If you are submitting a resource to be added to the awesome-azd README:

  • Name of resource
  • Resource author - who created this resource? (so we can credit them!)
  • What section should this resource be included in? -Is the resource an article? A video? Something else?

@hemarina
Copy link
Contributor

hemarina commented Oct 10, 2024 •
edited
Loading

@v-xuto Could you test these templates please?

@BigMorty
Copy link
Member Author

@vhvb1989, tags have been updated. thanks

@v-xuto
Copy link
Member

v-xuto commented Oct 11, 2024

@v-xuto Could you test these templates please?

Sure. Testing.

@v-xuto
Copy link
Member

v-xuto commented Oct 12, 2024

@hemarina, @BigMorty We have finished this template test, and we filed six issues. Please review.

@vhvb1989
Copy link
Member

@BigMorty ,

The tag "http" is not defined in ./src/data/tags.tsx.

@BigMorty
Copy link
Member Author

Thanks, I will work on fixing these issues and the tag.

@BigMorty BigMorty changed the title Add seven new Azure Functions templates Add new Azure Functions templates Oct 17, 2024
@BigMorty
Copy link
Member Author

@v-xuto @hemarina

  • I could not repo the F5 issue, F5 worked fine
  • I fixed the links in the two Readme files
  • I removed the AI template from the PR, we are going to refactor that into three simpler templates instead
  • I removed the http tag, it is not really needed

@v-xuto
Copy link
Member

v-xuto commented Oct 17, 2024

@BigMorty The following are the latest status of each issue:

@BigMorty
Copy link
Member Author

@v-xuto, thanks for the additional details on the F5 issue with Java. I updated the steps for running in VS. No need to change to http folder before open VSCode, do this from the root instead. I also cleaned up a few duplicate files.
Also fixed the other broken link,.
Should all be good now. thanks!

@hemarina
Copy link
Contributor

hemarina commented Oct 18, 2024 •
edited
Loading

@BigMorty Could you add the following code to tags.txs? Tests are failed due to Error: The tag "powershell" is not defined in ./src/data/tags.tsx. I tried to push directly and failed due to permission deny.

At L124:

  | "powershell";

At L282:

powershell: {
    label: "PowerShell",
    description: "Template architecture uses PowerShell",
    type: "Tools",
  },

@v-xuto
Copy link
Member

v-xuto commented Oct 21, 2024

@hemarina All issues have been fixed (except AI template issue#17). There are currently no issues with this template. Please review.

@BigMorty
Copy link
Member Author

@hemarina, I added the PowerShell tag - 02608d0

hemarina
hemarina approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@hemarina hemarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your contributions!

@hemarina hemarina merged commit d1e3006 into Azure:main Oct 21, 2024
2 checks passed
@BigMorty
Copy link
Member Author

Thanks all. @hemarina, when can we expect these to show here - https://azure.github.io/awesome-azd/?tags=functions

@hemarina
Copy link
Contributor

@BigMorty Our weekly release is on Wednesday. If you would like to see the template early than that, we also do release by request.

@BigMorty
Copy link
Member Author

@hemarina, Wednesday is fine. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vhvb1989 vhvb1989 vhvb1989 left review comments

@hemarina hemarina hemarina approved these changes

@gkulin gkulin Awaiting requested review from gkulin gkulin is a code owner

@rajeshkamal5050 rajeshkamal5050 Awaiting requested review from rajeshkamal5050 rajeshkamal5050 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BigMorty @hemarina @v-xuto @vhvb1989