Fixed possible nil pointers in Advisor scan

Azure · May 22, 2023 · b58b067 · b58b067
1 parent 1b1cd44
commit b58b067
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/internal/scanners/advisor.go b/internal/scanners/advisor.go
@@ -78,9 +78,15 @@ func (s *AdvisorScanner) ListRecommendations() ([]AdvisorResult, error) {
 	for _, recommendation := range recommendations {
 		ar := AdvisorResult{
 			SubscriptionID: s.config.SubscriptionID,
-			Name:           *recommendation.Properties.ImpactedValue,
-			Category:       string(*recommendation.Properties.Category),
-			Description:    *recommendation.Properties.ShortDescription.Problem,
+		}
+		if recommendation.Properties.ImpactedValue != nil {
+			ar.Name = *recommendation.Properties.ImpactedValue
+		}
+		if recommendation.Properties.Category != nil {
+			ar.Category = string(*recommendation.Properties.Category)
+		}
+		if recommendation.Properties.ShortDescription != nil && recommendation.Properties.ShortDescription.Problem != nil {
+			ar.Description = *recommendation.Properties.ShortDescription.Problem
 		}
 		if recommendation.Properties.ImpactedField != nil {
 			ar.Type = *recommendation.Properties.ImpactedField