Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Typo #176 #177

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Fixed Typo #176 #177

merged 1 commit into from
Dec 19, 2023

Conversation

cmendible
Copy link
Member

Description

Fixed Typo in Traffic Manger Scan

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #176

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Unit tests passing

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (55ccd89) 46.41% compared to head (404cb23) 46.41%.

Files Patch % Lines
internal/scanners/traf/traf.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #177   +/-   ##
=======================================
  Coverage   46.41%   46.41%           
=======================================
  Files          72       72           
  Lines        3456     3456           
=======================================
  Hits         1604     1604           
  Misses       1839     1839           
  Partials       13       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member Author

@cmendible cmendible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmendible cmendible merged commit 61c7516 into main Dec 19, 2023
12 checks passed
@cmendible cmendible deleted the issue-176 branch December 19, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mispell Traffic word instead of Trraffic Manager in Resource
2 participants