Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add synapse workspace & synapse spark pool cmd's #204

Merged
merged 11 commits into from
Apr 23, 2024

Conversation

vanwinkelseppe
Copy link
Contributor

@vanwinkelseppe vanwinkelseppe commented Apr 19, 2024

Description

Added a scanner for

  • Synapse Analytics Workspaces
  • Synapse Spark Pools
  • Synapse Dedicated SQL Pools

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #203

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Unit tests passing

@vanwinkelseppe
Copy link
Contributor Author

vanwinkelseppe commented Apr 20, 2024

@cmendible updated the code to remove the ineffectual assignment to err in the linter.

  • Linter passing

@vanwinkelseppe
Copy link
Contributor Author

Also added Azure Synapse Dedicated SQL pools

Copy link
Member

@cmendible cmendible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

This implementation potentially scans for workspaces 3 times if a user runs a scan without subcommands.

In order to avoid this:

  • Centralize all synapse scans under the synw sub command and remove the other two.
  • synw scan should run synw scan as well as syndp so we query for workspaces just once.
  • You can check a similar behavior in the asp scanner here:
    rules := a.getPlanRules()

@vanwinkelseppe
Copy link
Contributor Author

Thanks for your contribution!

This implementation potentially scans for workspaces 3 times if a user runs a scan without subcommands.

In order to avoid this:

  • Centralize all synapse scans under the synw sub command and remove the other two.
  • synw scan should run synw scan as well as syndp so we query for workspaces just once.
  • You can check a similar behavior in the asp scanner here:
    rules := a.getPlanRules()

Thanks! Will do this asap!

Copy link
Member

@cmendible cmendible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmendible cmendible merged commit 177378b into Azure:main Apr 23, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Azure Synapse Analytics scanner
2 participants