-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add synapse workspace & synapse spark pool cmd's #204
Conversation
@cmendible updated the code to remove the ineffectual assignment to err in the linter.
|
Also added Azure Synapse Dedicated SQL pools |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
This implementation potentially scans for workspaces 3 times if a user runs a scan without subcommands.
In order to avoid this:
- Centralize all synapse scans under the
synw
sub command and remove the other two. synw
scan should runsynw
scan as well assyndp
so we query for workspaces just once.- You can check a similar behavior in the
asp
scanner here:azqr/internal/scanners/asp/asp.go
Line 44 in 6f1e35b
rules := a.getPlanRules()
Thanks! Will do this asap! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Added a scanner for
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #203
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: